-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3090
-----------------------------------------------------------
Looks good, I'm not too familiar with the timing stuff as it was..
What does strike me though is how similar in concept it is to life-cycle
events. I took a look at the lifecycle events:
ON_PRELOADED: 'onPreloaded',
ON_NAVIGATED: 'onNavigated',
ON_CLOSED: 'onClosed',
ON_UNLOADED: 'onUnloaded',
ON_RENDER: 'onRender'
And it looks like they could be enhanced (if no one has any objections) to add
the ability to do timings so we don't have to bake the code into shindig (a
container impl could provide it)
We would need:
ON_BEFORE_PRELOAD
ON_BEFORE_NAVIGATE
ON_BEFORE_CLOSE
ON_BEFORE_RENDER
Unfortunately, ON_RENDER actually gets fired BEFORE the render call. It would
be nice to replace this with ON_BEFORE_RENDER and make ON_RENDER fire in the
onload event of the iframe.
Anyone else have any thoughts?
- Dan
On 2011-11-01 23:49:25, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2616/
> -----------------------------------------------------------
>
> (Updated 2011-11-01 23:49:25)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> We already have a callback function for navigating gadgets in the common
> container which can be used to print timing information. Problem is if you
> preload the gadget before navigating the timing information during navigation
> is 0. It would be helpful to print timing information for preloading as well.
>
>
> This addresses bug SHINDIG-1653.
> https://issues.apache.org/jira/browse/SHINDIG-1653
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/container_test.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js
> 1190425
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/util_test.js
> 1190425
>
> Diff: https://reviews.apache.org/r/2616/diff
>
>
> Testing
> -------
>
> Modified sample container to log this information and updated unit tests.
>
>
> Thanks,
>
> Ryan
>
>
