> On 2011-11-18 21:51:25, Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, > > line 556 > > <https://reviews.apache.org/r/2616/diff/4/?file=59402#file59402line556> > > > > Do actions not care about the ON_CLOSED event anymore?
ON_CLOSED used to get called before the site was actually closed, so I moved it after we close the site. Now ON_BEFORE_CLOSE gets called before site.close so in order to not regress anything actions and open search should listen for on_before_close. I will add Igor and Matt to the review so they are aware. - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2616/#review3363 ----------------------------------------------------------- On 2011-11-18 21:16:31, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2616/ > ----------------------------------------------------------- > > (Updated 2011-11-18 21:16:31) > > > Review request for shindig. > > > Summary > ------- > > I have added additional lifecycle handlers. My primary use case here is to > be able to time the different events that take place as a gadget is rendered, > but these additional lifecycle handlers may be used for other things as well. > > > This addresses bug SHINDIG-1653. > https://issues.apache.org/jira/browse/SHINDIG-1653 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js > 1203746 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js > 1203746 > > Diff: https://reviews.apache.org/r/2616/diff > > > Testing > ------- > > Modified sample container to log this information and updated unit tests. > > > Thanks, > > Ryan > >
