----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2616/#review3105 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js <https://reviews.apache.org/r/2616/#comment6912> Is there harm in setting this if it *is* undefined? http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js <https://reviews.apache.org/r/2616/#comment6913> Can you check truthy here? if (this.gadgetLoadedCallback_) Empty string is falsey in js, you don't need to explicitly check for it. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js <https://reviews.apache.org/r/2616/#comment6914> Can you use double quotes to quote the single quote strings? "({'" + blah + "':'" That could eliminate all of those slashes. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js <https://reviews.apache.org/r/2616/#comment6915> Again, is truthiness something that you can use here instead of the typeof and emptystring check? - Dan On 2011-11-01 23:49:25, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2616/ > ----------------------------------------------------------- > > (Updated 2011-11-01 23:49:25) > > > Review request for shindig. > > > Summary > ------- > > We already have a callback function for navigating gadgets in the common > container which can be used to print timing information. Problem is if you > preload the gadget before navigating the timing information during navigation > is 0. It would be helpful to print timing information for preloading as well. > > > This addresses bug SHINDIG-1653. > https://issues.apache.org/jira/browse/SHINDIG-1653 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/container_test.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js > 1190425 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/util_test.js > 1190425 > > Diff: https://reviews.apache.org/r/2616/diff > > > Testing > ------- > > Modified sample container to log this information and updated unit tests. > > > Thanks, > > Ryan > >
