-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3180/
-----------------------------------------------------------
(Updated 2011-12-22 19:58:30.507072)
Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse Ciancetta,
and Stanton Sievers.
Changes
-------
Moved container token refresh impl to service so that it could more easily be
used by the getGadgetMetadata function (which is where it's really needed, not
surrounding navigate).
Left the public api on Container which calls into service for the impl.
Adjusted if/else line style to: } else {
Tests are now working with the getGadgetMetadata call wrapped in the
updateContainerSecurityToken call.
Summary
-------
Initial review of 1st change. Allowing common container to manage container
token refreshes. Also, refresh of gadget security tokens will now wait for
valid container security token before trying to refresh.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js
1222407
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1222407
Diff: https://reviews.apache.org/r/3180/diff
Testing
-------
Tested code in a private container with some examples of setting no refresh
(ttl = 0) and setting an initial token (if it was written by jsp page to avoid
transaction) etc..
Thanks,
Dan
