----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3180/ -----------------------------------------------------------
(Updated 2011-12-22 21:00:32.001973) Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse Ciancetta, and Stanton Sievers. Changes ------- Added container token refresh function to sample container. Started porting of Jesse's review here: https://reviews.apache.org/r/1632 and ran into some questions. (todo comments in gadget_site.js) I'm wondering how a container would choose to persist a gadget, and what that would mean for it's token. Perhaps some other xhr to save the gadget and get a moduleId and then the container would set the moduleId of the site, which could trigger a token refresh (with the new moduleId). Some other interesting questions I have from reading Jesse's review: How would we tell the server to use a certain moduleId in a metadata request? Should we do that, or should we let any instances of the gadget which are not persisted use a default token with no moduleId in it? Should we fetch specific tokens, post metadata request, for a gadget if we know we are "restoring" a saved instance? (Compare patch versions 4 and 5 to see the changes in this update.) Summary ------- Initial review of 1st change. Allowing common container to manage container token refreshes. Also, refresh of gadget security tokens will now wait for valid container security token before trying to refresh. Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1222407 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1222407 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1222407 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js 1222407 Diff: https://reviews.apache.org/r/3180/diff Testing ------- Tested code in a private container with some examples of setting no refresh (ttl = 0) and setting an initial token (if it was written by jsp page to avoid transaction) etc.. Thanks, Dan
