> On June 26, 2012, 5:51 p.m., Dan Dumont wrote: > > /trunk/features/src/main/javascript/features/core.io/io.js, line 226 > > <https://reviews.apache.org/r/5589/diff/3/?file=116563#file116563line226> > > > > I'm not sure that we want to throw here. > > We should probably be constructing a resp with a error/rc children > > similar to the error cases above.
Thanks for the feedback. I've updated it to match the other parser errors. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8609 ----------------------------------------------------------- On June 26, 2012, 5:59 p.m., Matthew Reiter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5589/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 5:59 p.m.) > > > Review request for shindig. > > > Description > ------- > > Code review for my proposed solution to "makeRequest fails on IE when ActiveX > is disabled". > > > This addresses bug SHINDIG-1808. > https://issues.apache.org/jira/browse/SHINDIG-1808 > > > Diffs > ----- > > /trunk/features/src/main/javascript/features/core.io/io.js 1354070 > > Diff: https://reviews.apache.org/r/5589/diff/ > > > Testing > ------- > > Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with > ActiveX disabled and IE 9 with ActiveX enabled. > > > Thanks, > > Matthew Reiter > >
