> On June 27, 2012, 4:38 p.m., Stanton Sievers wrote: > > Matt, please update the JIRA with the latest patch and grant ASF license. > > I'll get this committed once that is done. > > Matthew Reiter wrote: > I'll add the patch to the bug once the unit tests I've added are > approved. Am I correct in assuming that I should use the "Submit Patch" > button to do so?
"Submit Patch" is misleading. To attach the patch please use the More Actions -> Attach Files menu. - Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5589/#review8656 ----------------------------------------------------------- On June 27, 2012, 10:44 p.m., Matthew Reiter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5589/ > ----------------------------------------------------------- > > (Updated June 27, 2012, 10:44 p.m.) > > > Review request for shindig. > > > Description > ------- > > Code review for my proposed solution to "makeRequest fails on IE when ActiveX > is disabled". > > > This addresses bug SHINDIG-1808. > https://issues.apache.org/jira/browse/SHINDIG-1808 > > > Diffs > ----- > > /trunk/features/src/main/javascript/features/core.io/io.js 1354070 > /trunk/features/src/test/javascript/features/core.io/iotest.js 1354070 > > Diff: https://reviews.apache.org/r/5589/diff/ > > > Testing > ------- > > Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with > ActiveX disabled and IE 9 with ActiveX enabled. > > > Thanks, > > Matthew Reiter > >
