> On June 26, 2012, 11:25 p.m., Henry Saputra wrote: > > Correct me if I am wrong, but the issue about templates defined in the > > module inline are no longer available to the client apis happen regardless > > of this patch right? I dont see how this patch affect the inline template.
Henry, you are correct, that issue exists regardless of this patch. This patch just makes it possible to access template library defined templates from the client API. I was just pointing it out so people didn't try and use both at the same time from client libraries. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8645 ----------------------------------------------------------- On June 26, 2012, 11:21 p.m., Chris Geer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5600/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 11:21 p.m.) > > > Review request for shindig. > > > Description > ------- > > OS Templates that were defined in template libraries were not available from > the client APIs because registration was failing. This patch registers them > so they can be used. > > One side effect is that due to some timing with onLoadHandlers and templates, > if template libraries are used, templates defined in the module statically > are no longer available to the client apis. This patch will allow you to use > one or the other from the client libraries but not both. > > > This addresses bug SHINDIG-1788. > https://issues.apache.org/jira/browse/SHINDIG-1788 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml > PRE-CREATION > /trunk/features/src/main/javascript/features/opensocial-templates/loader.js > 1354233 > > /trunk/features/src/main/javascript/features/opensocial-templates/template.js > 1354233 > > Diff: https://reviews.apache.org/r/5600/diff/ > > > Testing > ------- > > Created an example gadget and tested it in the samplecontainer runtime. > > > Thanks, > > Chris Geer > >
