----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8670 -----------------------------------------------------------
I noticed in the JIRA you removed the patch...please keep the patch and the JIRA and make sure it is the most up to date patch. You also need to grant the ASF license so we can commit it for you. /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml <https://reviews.apache.org/r/5600/#comment18332> Where is this library? /trunk/features/src/main/javascript/features/opensocial-templates/template.js <https://reviews.apache.org/r/5600/#comment18331> When reading the code, if a param is optional it is good to denote that in the parameter name, such as opt_tag. Also I guess you can use the JS doc annotation suggested here http://code.google.com/p/jsdoc-toolkit/wiki/TagParam - Ryan Baxter On June 26, 2012, 11:21 p.m., Chris Geer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5600/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 11:21 p.m.) > > > Review request for shindig. > > > Description > ------- > > OS Templates that were defined in template libraries were not available from > the client APIs because registration was failing. This patch registers them > so they can be used. > > One side effect is that due to some timing with onLoadHandlers and templates, > if template libraries are used, templates defined in the module statically > are no longer available to the client apis. This patch will allow you to use > one or the other from the client libraries but not both. > > > This addresses bug SHINDIG-1788. > https://issues.apache.org/jira/browse/SHINDIG-1788 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml > PRE-CREATION > /trunk/features/src/main/javascript/features/opensocial-templates/loader.js > 1354233 > > /trunk/features/src/main/javascript/features/opensocial-templates/template.js > 1354233 > > Diff: https://reviews.apache.org/r/5600/diff/ > > > Testing > ------- > > Created an example gadget and tested it in the samplecontainer runtime. > > > Thanks, > > Chris Geer > >
