> On June 28, 2012, 2:04 p.m., Dan Dumont wrote: > > /trunk/features/src/main/javascript/features/opensocial-templates/template.js, > > line 91 > > <https://reviews.apache.org/r/5600/diff/2/?file=117031#file117031line91> > > > > Could you be more descriptive of the actual functionality of the method > > in the comments here. Since the tag is optional, what happens if you don't > > provide it? > > > > (I know what happens, but can you put it in the jsdoc?)
OBE - reverted this method - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5600/#review8711 ----------------------------------------------------------- On June 28, 2012, 1:01 a.m., Chris Geer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5600/ > ----------------------------------------------------------- > > (Updated June 28, 2012, 1:01 a.m.) > > > Review request for shindig. > > > Description > ------- > > OS Templates that were defined in template libraries were not available from > the client APIs because registration was failing. This patch registers them > so they can be used. > > One side effect is that due to some timing with onLoadHandlers and templates, > if template libraries are used, templates defined in the module statically > are no longer available to the client apis. This patch will allow you to use > one or the other from the client libraries but not both. > > > This addresses bug SHINDIG-1788. > https://issues.apache.org/jira/browse/SHINDIG-1788 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/templates/TemplateClientAPI.xml > PRE-CREATION > /trunk/features/src/main/javascript/features/opensocial-templates/loader.js > 1354233 > > /trunk/features/src/main/javascript/features/opensocial-templates/template.js > 1354233 > > Diff: https://reviews.apache.org/r/5600/diff/ > > > Testing > ------- > > Created an example gadget and tested it in the samplecontainer runtime. > > > Thanks, > > Chris Geer > >
