----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6754/ -----------------------------------------------------------
Review request for shindig. Description ------- The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers. Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1373834 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1373834 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml 1373834 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.base/base.js 1373834 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/container_oauthpopup.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/feature.xml 1373834 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js 1373834 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/oauthpopup/oauthpopup-test.js 1373834 Diff: https://reviews.apache.org/r/6754/diff/ Testing ------- Fixed up tests for the changes. Thanks, Dan Dumont
