> On Aug. 25, 2012, 5:44 p.m., Stanton Sievers wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js, > > line 134 > > <https://reviews.apache.org/r/6754/diff/2/?file=145618#file145618line134> > > > > Do you really want to register an on load handler, or do you want to do > > a config init registration for rpc config? > > > > A config registration would allow you to get setup before a gadget has > > a chance to do anything. The use case I have in mind is a gadget doing > > OAuth popup actions as soon as their on load handler gets fired. May not > > be an issue, just figured I'd ask the question. :)
I don't think it's an issue, load handlers should be run in order of registration, and this should beat their registrations. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6754/#review10763 ----------------------------------------------------------- On Aug. 24, 2012, 5:56 p.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6754/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2012, 5:56 p.m.) > > > Review request for shindig. > > > Description > ------- > > The container will now handle the launching of oauth requests and fire onopen > and onclose events back into the requesting gadgets. This will allow > container implementations to override the default behavior and possibly > surface them in liteboxes rather than relying on window.open which is often > prevented by popup blockers. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1373834 > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.base/base.js > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/container_oauthpopup.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/feature.xml > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/oauthpopup/oauthpopup-test.js > 1373834 > > Diff: https://reviews.apache.org/r/6754/diff/ > > > Testing > ------- > > Fixed up tests for the changes. > > > Thanks, > > Dan Dumont > >
