----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6754/#review10831 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/container_oauthpopup.js <https://reviews.apache.org/r/6754/#comment23329> Should the parameters passed to this open be the same as the one above? If so can we make this code common between the two? - Ryan Baxter On Aug. 27, 2012, 8:18 p.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6754/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2012, 8:18 p.m.) > > > Review request for shindig. > > > Description > ------- > > The container will now handle the launching of oauth requests and fire onopen > and onclose events back into the requesting gadgets. This will allow > container implementations to override the default behavior and possibly > surface them in liteboxes rather than relying on window.open which is often > prevented by popup blockers. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/UPGRADING 1373834 > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.util.base/base.js > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/container_oauthpopup.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/feature.xml > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/oauthpopup/oauthpopup.js > 1373834 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/oauthpopup/oauthpopup-test.js > 1373834 > > Diff: https://reviews.apache.org/r/6754/diff/ > > > Testing > ------- > > Fixed up tests for the changes. > > > Thanks, > > Dan Dumont > >
