XJDKC commented on a change in pull request #731:
URL: https://github.com/apache/singa/pull/731#discussion_r440582387
##########
File path: python/singa/layer.py
##########
@@ -158,6 +217,21 @@ def _get_unique_name(self):
self.name = ''
return self.name
Review comment:
2. This scheme will reset the layer name many times.
```python
1. model.__init__
2. layer1.__init__
3. layer2.__init__
4. layer3.__init__
5. layer2.__setattr__: reset the name of layer3
6. layer1.__setattr__: reset the names of layer2 and layer3
7. model.__setattr__: reset the names of laye1, layer2 and layer3
```
And we can't get the params before the initialization because they are not
created yet at that time.
3. the tensor has a default name if user doesn't set the
name.https://github.com/apache/singa/blob/master/python/singa/tensor.py#L116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
