XJDKC commented on a change in pull request #731:
URL: https://github.com/apache/singa/pull/731#discussion_r440720540
##########
File path: python/singa/layer.py
##########
@@ -499,7 +581,7 @@ def initialize(self, x):
self.kernel_size[0],
self.kernel_size[1],
)
- w_name = self.name + Layer.sep + 'W'
+ w_name = self.get_param_name('W')
Review comment:
So users name the param tensors, we should raise a warning? Now, we name
layers and param tensors automatically in \_\_setattr\_\_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]