nudles commented on a change in pull request #731:
URL: https://github.com/apache/singa/pull/731#discussion_r440718156
##########
File path: python/singa/layer.py
##########
@@ -499,7 +581,7 @@ def initialize(self, x):
self.kernel_size[0],
self.kernel_size[1],
)
- w_name = self.name + Layer.sep + 'W'
+ w_name = self.get_param_name('W')
Review comment:
I mean if we use ` w_name = self.get_param_name('W')`, then we can also
write ` w_name = self.get_param_name('Weights')`.
I think we should not let the users name the param tensors to avoid such
issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
