The more reviewers, the better, but forcing it to be **REQUIRED** just doesn't make things better, IMO, it slows down the contribution process, people who take less part in reviewing works won't take more after the setting.
But as you called for more committers/PMC to take part in reviewing, we can try to work as what you proposed for some time without setting the rule explicitly, and check the outcome. Reviewers don't merge the PRs too hasty and wait 24+ hours for another reviewers during the trial period. -- GitHub @kezhenxu94 Apache SkyWalking, Apache Dubbo At 2020-02-16 10:30:25, "Sheng Wu" <[email protected]> wrote: >Hi Dev and committer team > >Since today, we have 207 contributors in our main repo. And many PRs landed >every week, which have to be approved by one person. But with the >increasement of the committer and the community, I want to ask your opinion >about > >Do we need to set up the rule for the main repo,* requiring two approvers >for every PR?* > >I am not a preferred answer, and Jian Tan asked about this in a PR several >months ago. >Recently, I and Zhenxu Ke are the most active reviewers, if we could have >more committers are willing to sign up to do the routine review, please let >me know. Routine review means you could review the PR(most) in 24 hours and >give feedback. > >Please reply to this mail in this form. > >*Name, Review Field(agent, backend or both). * > >If this gets passed, and we have reviewers more than 6, I will consider >this as a YES. This list will be shown up on the contributor page[1] as the >reviewer list. > > >[1] >https://github.com/apache/skywalking/blob/master/docs/en/guides/README.md > > >Sheng Wu 吴晟 > >Apache SkyWalking >Apache Incubator >Apache ShardingSphere, ECharts, DolphinScheduler podlings >Zipkin >Twitter, wusheng1108
