It's a good practice to share the ownership of the project. If the code can be reviewed by multiple eyes, the code quality will not be an issue. BTW, if you keep an eye on the PR, you will not be surprised when you try to do some modifications on the code :) +1 to invite more people to review the code.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sun, Feb 16, 2020 at 11:48 AM Sheng Wu <wu.sheng.841...@gmail.com> wrote: > > More importantly, I want to share the idea. > > Don't have to wait for me to express what is my idea. I just knew and took > part in the project from day one, nothing more. > If more people want to take part in and make decisions, let's do it. > > If currently, PMC and committer still think it is better to let me make the > final decision, I could live with it. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > Sheng Wu <wu.sheng.841...@gmail.com> 于2020年2月16日周日 上午11:45写道： > > > Hi > > > > In this discussion, I didn't start to think about the rules of GitHub. > > That is another discussion. > > As we know, in the community, people sometimes prefer contributing based > > on their own interests, rather than reviewing others. > > There is not a right or wrong thing. > > > > Please consider this just as a survey. If there are not enough people to > > be official reviewers, let's keep the status as same as current. > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > kezhenxu94 <kezhenx...@apache.org> 于2020年2月16日周日 上午11:37写道： > > > >> The more reviewers, the better, but forcing it to be **REQUIRED** > >> just doesn't make things better, IMO, it slows down the contribution > >> process, people who take less part in reviewing works won't take more > >> after the setting. > >> > >> > >> But as you called for more committers/PMC to take part in reviewing, > >> we can try to work as what you proposed for some time without setting > >> the rule explicitly, and check the outcome. Reviewers don't merge the > >> PRs too hasty and wait 24+ hours for another reviewers during the trial > >> period. > >> > >> > >> -- > >> > >> GitHub @kezhenxu94 > >> Apache SkyWalking, Apache Dubbo > >> > >> > >> At 2020-02-16 10:30:25, "Sheng Wu" <wush...@apache.org> wrote: > >> >Hi Dev and committer team > >> > > >> >Since today, we have 207 contributors in our main repo. And many PRs > >> landed > >> >every week, which have to be approved by one person. But with the > >> >increasement of the committer and the community, I want to ask your > >> opinion > >> >about > >> > > >> >Do we need to set up the rule for the main repo,* requiring two approvers > >> >for every PR?* > >> > > >> >I am not a preferred answer, and Jian Tan asked about this in a PR > >> several > >> >months ago. > >> >Recently, I and Zhenxu Ke are the most active reviewers, if we could have > >> >more committers are willing to sign up to do the routine review, please > >> let > >> >me know. Routine review means you could review the PR(most) in 24 hours > >> and > >> >give feedback. > >> > > >> >Please reply to this mail in this form. > >> > > >> >*Name, Review Field(agent, backend or both). * > >> > > >> >If this gets passed, and we have reviewers more than 6, I will consider > >> >this as a YES. This list will be shown up on the contributor page[1] as > >> the > >> >reviewer list. > >> > > >> > > >> >[1] > >> > > >> https://github.com/apache/skywalking/blob/master/docs/en/guides/README.md > >> > > >> > > >> >Sheng Wu 吴晟 > >> > > >> >Apache SkyWalking > >> >Apache Incubator > >> >Apache ShardingSphere, ECharts, DolphinScheduler podlings > >> >Zipkin > >> >Twitter, wusheng1108 > >> > >
