On Fri, Nov 13, 2009 at 18:30, Carsten Ziegeler <cziege...@apache.org> wrote:
> currently we have two testing bundles in commons, testing and slingtest.
> While the original idea of testing has been to have a general osgi/jcr
> testing framework, slingtest's idea is to add sling specific test helper
> stuff.
>
> Actually looking at the two bundles, the reality looks different.
> Commons testing contains dependencies to Sling already - so it is not
> common. slingtest contains only a single class.
>
> So I think we should:
> - merge the two into the new slingtest module (if someone comes up with
> a better name, I'm fine)
> - move it out of commons as it is not common stuff
> - maybe create a testing subfolder in the root where we put it?
>
> These changes would not cause any incompatibilities as commons-testing
> is released and would now be end of live with the new slingtest module
> being its successor. Once we've done the move, we simply release the new
> module asap. (No need to change the packages imho)

The SlingTestHelper class in commons/slingtest was meant to be for
commons/testing originally. I think Bertrand had to split the two
because of circular dependencies, although I don't know which exactly.
Probably api, jcr.api or jcr.resource, which are used by slingtest,
use commons/testing themselves.

If moving out of commons would solve this somehow, +1 for merging them back.

Regards,
Alex

-- 
Alexander Klimetschek
alexander.klimetsc...@day.com

Reply via email to