On Mon, Nov 16, 2009 at 11:15 AM, Carsten Ziegeler <cziege...@apache.org> wrote: > Bertrand Delacretaz wrote: >> On Mon, Nov 16, 2009 at 9:59 AM, Carsten Ziegeler <cziege...@apache.org> >> wrote: >>> ...1. o.a.s.adapter.internal >>> >>> Helper stuff if you're using adapter managers. If this has some common >>> interest we could move this to the sling testing module. >> >> Did you check if it's currently used somewhere? >> If not, ok to remove it. > Strangely this is just used in the new slingtest module....so it seems > we can remove it "somehow" (or merge it into slingtest)...
Right, so those are classes that came with the SLING-1166 patch, they do belong in the slingtest module. >>>... 4. o.a.s.c.testing.osgi >>> Just mocks for some OSGi interfaces - I see no need for these as mock >>> libs like jmock or easymock can be used instead. >> >> I assume those classes are used in existing code, did you check the >> impact on removing them? > Afaik, they are used - they could be easily replaced, but I think we can > remove these without removing its usage :) The testing bundle is > released, so if people want to use it they can use the latest release. A > newer version won't have these anymore. > And I would replace the usage in our sling code base over time.... Problem is, if you remove them, and we need to update the tests that use them, and in the meantime commons/testing includes new stuff that those tests need, we have to rewrite those tests completely... (clear enough? ;-) I'd much prefer modifying the tests first, so that those mock classes are not needed anymore, and only then remove those mocks. Or, for now, just mark those mocks deprecated to remind us that we want to do that change. I'm quite busy with other stuff this week and the next, won't have much time to help on that unfortunately. -Bertrand
