[ 
https://issues.apache.org/jira/browse/SLING-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784115#action_12784115
 ] 

Felix Meschberger commented on SLING-1197:
------------------------------------------

Thanks for providing the patch.

Comments: I am investigating whether it would be possible to merge the 
launchpad/bundles, launchpad/app and launchpad/webapp into a single 
launchpad/launcher module to prevent needless steps building the Sling launcher 
in the two forms.

This requires (only) slight adaptions to your patch:

   * The packaging should be configurable per execution (and default to the 
project packaging) to enable
        running the plugin multiple times in the same project with different 
configurations
   * Web Support Bundle sould be enhanced as follows:
          - allow overwride by configuration (already contained in the patch)
          - if packaging (configured or project packaging) is war: use Felix 
Http Bridge by default
          - if packaging is jar: use Felix Http Service by default (instead of 
Pax)

In any case, this plugin is a great addition. Thanks alot.

WDYT ?

> new prepare-package Maven goal to simplify launchpad poms
> ---------------------------------------------------------
>
>                 Key: SLING-1197
>                 URL: https://issues.apache.org/jira/browse/SLING-1197
>             Project: Sling
>          Issue Type: New Feature
>          Components: Maven Plugins
>            Reporter: Justin Edelson
>         Attachments: SLING-1197-updated.patch, SLING-1197.patch
>
>
> See http://www.mail-archive.com/[email protected]/msg01908.html for 
> discussion

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to