stbischof commented on a change in pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612749947
##########
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##########
@@ -174,8 +179,9 @@ protected static void parseArgs(final LauncherConfig
config, final String[] args
final Option fwkProperties = Option.builder(OPT_FRAMEWORK_PROPERTIES)
.longOpt("framework-properties")
.desc("Set framework properties")
+ .hasArg()
.optionalArg(true)
Review comment:
The optional arg is important for the docker setup. In the docker file
we delegate every env to a option. So it could be that most Options are empty.
And if we do jott have opt arg the cliparser will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
