enapps-enorman commented on a change in pull request #24:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612785693



##########
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##########
@@ -174,8 +179,9 @@ protected static void parseArgs(final LauncherConfig 
config, final String[] args
         final Option fwkProperties = Option.builder(OPT_FRAMEWORK_PROPERTIES)
                 .longOpt("framework-properties")

Review comment:
       Ok, I now see how the Dockerfile was using those ENV configurations and 
it looks like it may be assuming that -D accepts a list of name=value 
properties?
   
   I could be wrong, but I'm not seeing where Apache cli automatically handles 
a list of properties in that way.  And as far as I know, defining a system 
property with a "-D" jvm arg expects only a single name=value and not a list.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to