enapps-enorman commented on a change in pull request #24:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24#discussion_r612790461
##########
File path: src/main/java/org/apache/sling/feature/launcher/impl/Main.java
##########
@@ -174,8 +179,9 @@ protected static void parseArgs(final LauncherConfig
config, final String[] args
final Option fwkProperties = Option.builder(OPT_FRAMEWORK_PROPERTIES)
.longOpt("framework-properties")
.desc("Set framework properties")
+ .hasArg()
.optionalArg(true)
Review comment:
I see. Would you be opposed to changing the Dockerfile to include the
"-D" in the FRAMEWORK_PROPERTIES env value string before each name=value and
separate each of those items with a space? That might make it simpler to parse
and avoid troubles with escaping the commas (if any) in the property name or
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
