[ 
https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734686#comment-13734686
 ] 

Carsten Ziegeler commented on SLING-2987:
-----------------------------------------

Thanks for the work, Bertrand.

For the API, I think there are some things which should be changed as well (we 
discussed these briefly in the original thread):
- we don't need a ResultLog, the result can have a string (array/list) of 
messages
- the result should not be based on the level of a log message, but have a 
level to be set (so we need an enum for that)
- the result should not hold the service, it should be a plain data object
- I assume the info props of the HealthCheck are also OSGi service props?
- not sure if we need the HealthCheckSelector, it rather looks like an utility 
method
                
> Simplified health check services
> --------------------------------
>
>                 Key: SLING-2987
>                 URL: https://issues.apache.org/jira/browse/SLING-2987
>             Project: Sling
>          Issue Type: Improvement
>          Components: Health Check
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: webconsole-is-back.jpg
>
>
> After some prototyping, the health check tools are ready for a rewrite that 
> will make them simpler and more OSGi friendly. 
> The functionality will be similar but with much less code, more focused on 
> the actual use cases that have emerged during prototyping. 
> The new API is being discussed on list, 
> http://markmail.org/thread/i6ib7tgax4cn2sss

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to