[
https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734873#comment-13734873
]
Carsten Ziegeler commented on SLING-2987:
-----------------------------------------
For the ResultLog:
Right now, the caller passed in a result log instance and forces the HC service
to call appropriate log messages, finally depending if a message with a
specific log level arrived, the result is either ok or fail.
I think, when calling the check method of the HC service, this method doesn't
take any argument, but just returns a result object - this result object has at
least two methods, so something like:
- (boolean)success(); (though I would prefer an enum)
- (String[]) getMessages(); // can also be a list etc.
And that's it - how the HC service does the check and how it determines whether
it passes or not is up to the service.
I'm not sure if the messages should be structured like a log message in
general, I would expect that we have different messages: information messages
telling what has been tested, result messages showing and explaining the
result, and maybe advice messages suggesting how to fix the problem, what to
check etc. But I think this doesn't directly map to typical log levels.
Now, for scripted tests, using the log approach might be useful. So you can
define a hc scripting api containing the ResultLog class and defining that this
is set when a HC script is called and for this case the level of the log
messages coming from the script is evaluated like today.
> Simplified health check services
> --------------------------------
>
> Key: SLING-2987
> URL: https://issues.apache.org/jira/browse/SLING-2987
> Project: Sling
> Issue Type: Improvement
> Components: Health Check
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Attachments: webconsole-is-back.jpg
>
>
> After some prototyping, the health check tools are ready for a rewrite that
> will make them simpler and more OSGi friendly.
> The functionality will be similar but with much less code, more focused on
> the actual use cases that have emerged during prototyping.
> The new API is being discussed on list,
> http://markmail.org/thread/i6ib7tgax4cn2sss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
