[
https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734813#comment-13734813
]
Bertrand Delacretaz commented on SLING-2987:
--------------------------------------------
Thanks for you review!
> - we don't need a ResultLog, the result can have a string (array/list) of
> messages
> The log could maybe be part of a scripting api for hcs
Not sure what you mean - we could use a list of String for the messages, where
by convention each one starts with the log level, like "DEBUG this is a
message", is that what you mean? I'm not sure why you think it's better than
what we have now - selecting logs by level is useful in the webconsole and
maybe other places - but of course that would also work with a "structured
string".
> - the result should not be based on the level of a log message, but have a
> level to be set (so we need an enum for that)
You mean setting a specific level by configuration, and any logs at or above
that are considered failures? That would work, and we can keep the current WARN
level as the default value. See also my discussion of a different
ResultThatHasAValue model on the dev list, having a more generic value/range
model might be useful, in addition to the logs triggering failures.
> - the result should not hold the service, it should be a plain data object
makes sense, currently that's only used to access the info() map
> - I assume the info props of the HealthCheck are also OSGi service props?
that's a partial copy for now, might make sense to just copy all service
properties
> - not sure if we need the HealthCheckSelector, it rather looks like an
> utility method
Yes, it's mostly that - what do you suggest, putting that class in a util
package and clients bundles can embed it as needed?
> Simplified health check services
> --------------------------------
>
> Key: SLING-2987
> URL: https://issues.apache.org/jira/browse/SLING-2987
> Project: Sling
> Issue Type: Improvement
> Components: Health Check
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Attachments: webconsole-is-back.jpg
>
>
> After some prototyping, the health check tools are ready for a rewrite that
> will make them simpler and more OSGi friendly.
> The functionality will be similar but with much less code, more focused on
> the actual use cases that have emerged during prototyping.
> The new API is being discussed on list,
> http://markmail.org/thread/i6ib7tgax4cn2sss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
