[ 
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288488#comment-14288488
 ] 

Stefan Seifert commented on SLING-4212:
---------------------------------------

a simple solution would be: always try to resolve all paths. if it least one 
path resolving fails the whole injection fails, regardless of required or 
optional settings. then we do not have the described problems and the code 
would be simplified.
does this still fulfill your requirements on the injector?

> Sling Models: Allow multiple values from ValueMap in the resource-path 
> injector
> -------------------------------------------------------------------------------
>
>                 Key: SLING-4212
>                 URL: https://issues.apache.org/jira/browse/SLING-4212
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: santiago garcĂ­a pimentel
>            Assignee: Stefan Seifert
>             Fix For: Sling Models API 1.2.0, Sling Models Impl 1.2.0
>
>         Attachments: resourcePath-API.patch, resourcePath-API_updated.patch
>
>
> The current implementation of the resource-path injector does not support 
> multiple values. I think it could be useful to inject a list of paths from 
> the valuemap.
>  I have created a small patch to allow this. Right now it only allows them 
> from the value map since I didn't want to change the API without consulting 
> you first. I you agree I can do this change as well. I also added a test case 
> for it.
> You can see a pull request in https://github.com/apache/sling/pull/51
> If there anything I can do to improve this patch, please let me know.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to