[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289232#comment-14289232 ]
santiago garcía pimentel commented on SLING-4212: ------------------------------------------------- [~sseif...@pro-vision.de] Yes, the code to check if it is required or optional is a bit messy, but I could not find any other way. An all or nothing approach would not be ideally for me, but I think it'll work good enough. I think that adding a new interface is too much struggle for only one feature. I can make some additional changes later (I'm not sure I'll have a lot of time recently) and update the patch. Maybe I would just have to check a previous commit. Im not sure. > Sling Models: Allow multiple values from ValueMap in the resource-path > injector > ------------------------------------------------------------------------------- > > Key: SLING-4212 > URL: https://issues.apache.org/jira/browse/SLING-4212 > Project: Sling > Issue Type: Improvement > Components: Extensions > Reporter: santiago garcía pimentel > Assignee: Stefan Seifert > Fix For: Sling Models API 1.2.0, Sling Models Impl 1.2.0 > > Attachments: resourcePath-API.patch, resourcePath-API_updated.patch > > > The current implementation of the resource-path injector does not support > multiple values. I think it could be useful to inject a list of paths from > the valuemap. > I have created a small patch to allow this. Right now it only allows them > from the value map since I didn't want to change the API without consulting > you first. I you agree I can do this change as well. I also added a test case > for it. > You can see a pull request in https://github.com/apache/sling/pull/51 > If there anything I can do to improve this patch, please let me know. -- This message was sent by Atlassian JIRA (v6.3.4#6332)