Hi Carsten Yes, you could say that. It provides these additional features:
- Executable Jar file - Provides a Sling 12 FM - Allows to execute Sling in the background with a listening port for management - Allows to stop the Sling instance from another process / terminal - Part of the Sling Start Feature Maven Plugin as it needs to execute Sling in the background and then end it at the end If you are thinking to incorporate this into the Feature Launcher that is fine with me. - Andy > On Jan 22, 2020, at 10:23 PM, Carsten Ziegeler <[email protected]> wrote: > > Hi Andreas, > > thanks, so the feature starter is - simplified - an improved feature launcher > already containing all the required pieces including a basic feature model. > Is that correct? > > Regards > Carsten > > On 23.01.2020 01:42, Andreas Schaefer wrote: >> Hi Carsten >> That is not what I had in mind. The Feature Starter is only containing the >> Feature Launcher and its necessary components to get it working (extensions) >> and the Sling FM file. The rest is downloaded and started through the >> Feature Launcher as if you started it with the Feature Launcher. >> The JAR file has two options: >> 1) Provide an override of the Sling FM to run your very own Sling or Sling / >> Customized FMs >> 2) Provide additional FMs to add your customized FMs to the released Sling >> FM / instance >> The rest of the options are the same as for the Sling Starter even though >> the Launcher Home is not supported yet. >> This means that a user can either start Sling or can start its own >> project(s) + Sling with the Sling Feature Starter. >> - Andy >>> On Jan 21, 2020, at 8:54 AM, Carsten Ziegeler <[email protected]> wrote: >>> >>> So it seems you are suggestion, that if someone wants to build a Sling >>> application, you clone/fork the feature-starter project, add your own >>> feature models and build the project, right? So this is kind of a template >>> for an own application project. >>> >>> Lets assume we go this route, how would we change the current sling-starter >>> project, which is the demo application we have? >>> >>> Regards >>> Carsten >>> >>> On 20.01.2020 07:05, Carsten Ziegeler wrote: >>>> Can you explain a little bit more how this works for users wanting to >>>> build an application? >>>> Today, you can create your own maven project, add/import provisioning >>>> models and build a startable jar (and a webapp which we don't need to >>>> support for feature models right now). You can then use this jar without >>>> any tooling. >>>> Thanks >>>> Carsten >>>> On 20.01.2020 01:58, Andreas Schaefer wrote: >>>>> As far as I see the 'sling-org-apache-sling-feature-starter’ this is not >>>>> just a test but rather the official way to start Sling XX. It does have >>>>> the option to add additional Feature Models (customer FMs) to the startup >>>>> and we can also add startup scripts so that it can be launched as a Unix >>>>> style service. >>>>> >>>>> I am fine with both approaches but we should make a decision one way or >>>>> the other. >>>>> >>>>> - Andy >>>>> >>>>>> On Jan 19, 2020, at 3:13 AM, Carsten Ziegeler <[email protected]> >>>>>> wrote: >>>>>> >>>>>> Sorry for getting late to this, but is the >>>>>> slingstart-feature-maven-plugin also creating the startable jar? >>>>>> >>>>>> While I suggested to create separate modules (which I continue to think >>>>>> is good), I'm a little bit worried about >>>>>> "org-apache-sling-feature-starter" - The current starter project is a >>>>>> demo setup for Sling, making it easy to try out and test Sling. >>>>>> Maybe it would be better to have the feature equivalent on the master >>>>>> branch of "sling-org-apache-sling-starter" and we move current master >>>>>> branch to a "provisioning-model" branch. >>>>>> >>>>>> Regards >>>>>> Carsten >>>>>> >>>>>> On 17.01.2020 17:41, Andreas Schaefer wrote: >>>>>>> Hi >>>>>>> This is a vote to promote the sling-org-apache-sling-feature-starter >>>>>>> and sling-slingstart-feature-maven-plugin to their own Sling Module. >>>>>>> This first module is the Feature Model counterpart of the >>>>>>> sling-org-apache-sling-starter and will create an executable JAR file. >>>>>>> The second is the counterpart of the sling-slingstart-maven-plugin >>>>>>> which will start and stop a Sling Instance from a Maven run and is >>>>>>> mostly used to run Integration Tests. >>>>>>> Sling Feature Starter: >>>>>>> 1. Code Location: both are in the ‘sling-whiteboard’ under >>>>>>> 'sling-org-apache-sling-feature-starter` folder >>>>>>> 2. Proposed Github Repo name (I just added feature into the name): >>>>>>> - sling-org-apache-sling-feature-starter >>>>>>> 3. Proposed artifact ids (group id: org.apache.sling) >>>>>>> - org.apache.sling.feature.starter >>>>>>> Sling Start Feature Maven Plugin: >>>>>>> 1. Code Location: both are in the ‘sling-whiteboard’ under >>>>>>> 'sling-slingstart-feature-maven-plugin` folder >>>>>>> 2. Proposed Github Repo names (I just added feature into the name): >>>>>>> - sling-slingstart-feature-maven-plugin >>>>>>> 3. Proposed artifact ids (group id: org.apache.sling) >>>>>>> - slingstart-feature-maven-plugin >>>>>>> As requested by Carsten I created separate modules for the Feature >>>>>>> counterparts. The modules work but the are not finished. The Sling >>>>>>> Feature Starter is actually using the Sling Start Feature Maven Plugin >>>>>>> to run the IT tests. >>>>>>> - Andy >>>>>> >>>>>> -- >>>>>> -- >>>>>> Carsten Ziegeler >>>>>> Adobe Research Switzerland >>>>>> [email protected] >>>>> >>> >>> -- >>> -- >>> Carsten Ziegeler >>> Adobe Research Switzerland >>> [email protected] > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > [email protected]
