Looks like 15555 is in. I’m looking at some before and after perfasm results today, but I have not seen anything concerning yet.
On Thu, Sep 9, 2021 at 4:51 PM Mark Miller <markrmil...@gmail.com> wrote: > I’m not quite finished but mostly through a review of SOLR-15555 - it’s > looking good. > > MRM > > On Wed, Sep 8, 2021 at 5:45 PM Mark Miller <markrmil...@gmail.com> wrote: > >> Hey has an alternate wip branch that is a bit more up to date, but still >> 9 different fails. >> >> He also has a benchmark for the benchmark module - that will help with >> testing, but we will definitely want to bang on that issue before release. >> I doubt that banging should hold up branching though - I’m sure we can make >> sure it’s solid before the release actually goes out. >> >> MRM >> >> On Wed, Sep 8, 2021 at 12:29 PM Timothy Potter <thelabd...@gmail.com> >> wrote: >> >>> Thank you for the updates Andrzej (via slack), Mike and Mark ... I'll >>> wait to hear back from Mike D on 15555 before proceeding with the RC >>> ... >>> >>> On Wed, Sep 8, 2021 at 11:12 AM Mark Miller <markrmil...@gmail.com> >>> wrote: >>> > >>> > I see there is alternate more recent SOLR-15555-wip branch i missed. >>> Taking a look at that. >>> > >>> > MRM >>> > >>> > On Wed, Sep 8, 2021 at 2:34 AM Mark Miller <markrmil...@gmail.com> >>> wrote: >>> >> >>> >> SOLR-15555 is critical query path and appears able to currently fail >>> up to 150 tests per run due to what looks mostly to be stats/metrics >>> races, though it’s hard to be sure that’s all with all the noise. Do you >>> have an update you can push Mike? >>> >> >>> >> MRM >>> >> >>> >> On Tue, Sep 7, 2021 at 12:35 PM David Smiley <dsmi...@apache.org> >>> wrote: >>> >>> >>> >>> Yes, in theory all commits to branch_8x are releasable at the time >>> in the minds of whoever is doing the commit/merge. Nevertheless, we humans >>> are very fallible and a baking period of a few days allows fix-ups and such >>> that ultimately improve quality a little. Of course this can delay >>> features a tiny bit and it's annoying to back-port to yet another branchp >>> pop when there are last-minute fixes. >>> >>> >>> >>> >>> >>> ~ David Smiley >>> >>> Apache Lucene/Solr Search Developer >>> >>> http://www.linkedin.com/in/davidwsmiley >>> >>> >>> >>> >>> >>> On Tue, Sep 7, 2021 at 11:53 AM Timothy Potter <thelabd...@gmail.com> >>> wrote: >>> >>>> >>> >>>> That's the process I've been following, so not sure what your point >>> is >>> >>>> David? The release branch didn't get cut last week because there >>> were >>> >>>> a number of JIRAs marked as blockers for 8.10 and we needed clarity >>> >>>> about how to move forward from the committers involved with those >>> >>>> tickets. Also, I don't see the point in requiring an extra backport >>> >>>> even if trivial if we know some features are coming in soon. From >>> >>>> where I sit, any code change that hits 8.x should be releasable >>> >>>> immediately or it shouldn't be committed. >>> >>>> >>> >>>> Tim >>> >>>> >>> >>>> On Tue, Sep 7, 2021 at 9:31 AM David Smiley <dsmi...@apache.org> >>> wrote: >>> >>>> > >>> >>>> > The release branch separate from cutting the RC used to be quite >>> normal; not exceptional. We should continue the practice for release >>> stability. It also gives clarity for those of us like me that have >>> something ready-ish to merge on which 8x version it should go into. >>> >>>> > >>> >>>> > ~ David Smiley >>> >>>> > Apache Lucene/Solr Search Developer >>> >>>> > http://www.linkedin.com/in/davidwsmiley >>> >>>> > >>> >>>> > >>> >>>> > On Tue, Sep 7, 2021 at 10:26 AM Timothy Potter < >>> thelabd...@gmail.com> wrote: >>> >>>> >> >>> >>>> >> Thanks for the heads up on LUCENE-10088 Mike. I'd still like to >>> cut >>> >>>> >> the release branch today, but won't start the RC until I get >>> word back >>> >>>> >> from you on that issue. I know this adds another backport for >>> you but >>> >>>> >> I can do that once it lands on 8x. >>> >>>> >> >>> >>>> >> On Tue, Sep 7, 2021 at 7:18 AM Michael McCandless >>> >>>> >> <luc...@mikemccandless.com> wrote: >>> >>>> >> > >>> >>>> >> > Hi Timothy, >>> >>>> >> > >>> >>>> >> > Heads up: I'm currently digging on this issue (LUCENE-10088: >>> "too many open files" in two failed builds, one in main, one in 8.x), and >>> I'm worried that maybe the root cause was backported to 8.x, i.e. maybe we >>> have a new file handle leak. >>> >>>> >> > >>> >>>> >> > If so, this might be a blocker for 8.10.0 release. >>> >>>> >> > >>> >>>> >> > I'll try to make progress today on getting to the root cause. >>> >>>> >> > >>> >>>> >> > Mike McCandless >>> >>>> >> > >>> >>>> >> > http://blog.mikemccandless.com >>> >>>> >> > >>> >>>> >> > >>> >>>> >> > On Thu, Sep 2, 2021 at 1:43 PM Timothy Potter < >>> thelabd...@gmail.com> wrote: >>> >>>> >> >> >>> >>>> >> >> Thanks for the feedback. >>> >>>> >> >> >>> >>>> >> >> My plan right now is to cut the release branch for 8.10 on >>> *Tuesday, >>> >>>> >> >> Sept. 7* (Monday is a US holiday). Hopefully this gives >>> enough time >>> >>>> >> >> to get the remaining issues addressed. >>> >>>> >> >> >>> >>>> >> >> After the release branch is cut, there should be some >>> discussion on >>> >>>> >> >> any new changes coming into that branch before RC1 comes out >>> (I >>> >>>> >> >> usually give a day or two after creating the release branch >>> before >>> >>>> >> >> creating RC1) >>> >>>> >> >> >>> >>>> >> >> May I please ask for some help with the Lucene 8.10 release >>> notes? >>> >>>> >> >> I'll do the notes for Solr. Please add the notes here: >>> >>>> >> >> >>> https://cwiki.apache.org/confluence/display/LUCENE/ReleaseNote8_10 >>> >>>> >> >> >>> >>>> >> >> Cheers, >>> >>>> >> >> Tim >>> >>>> >> >> >>> >>>> >> >> On Thu, Sep 2, 2021 at 11:15 AM Nicholas Knize < >>> nkn...@gmail.com> wrote: >>> >>>> >> >> > >>> >>>> >> >> > +1 to cutting the 8.10 branch and getting the release >>> moving. Will be good to get the #9981 patch out there. Tests seem happy for >>> a while. Thanks for chasing these blockers. >>> >>>> >> >> > >>> >>>> >> >> > Nicholas Knize, Ph.D., GISP >>> >>>> >> >> > Principal Engineer - Search | Amazon >>> >>>> >> >> > Apache Lucene PMC Member and Committer >>> >>>> >> >> > nkn...@apache.org >>> >>>> >> >> > >>> >>>> >> >> > >>> >>>> >> >> > On Sat, Aug 28, 2021 at 11:18 AM Michael McCandless < >>> luc...@mikemccandless.com> wrote: >>> >>>> >> >> >> >>> >>>> >> >> >> Yeah +1! Lucene's first "non floating point" compliant >>> release in a long time? >>> >>>> >> >> >> >>> >>>> >> >> >> Mike >>> >>>> >> >> >> >>> >>>> >> >> >> On Thu, Aug 26, 2021 at 4:09 AM Adrien Grand < >>> jpou...@gmail.com> wrote: >>> >>>> >> >> >>> >>> >>>> >> >> >>> +1 to a 8.10 release and cutting a branch next week >>> >>>> >> >> >>> >>> >>>> >> >> >>> On Tue, Aug 24, 2021 at 8:02 PM Timothy Potter < >>> thelabd...@gmail.com> wrote: >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> Hi folks, >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> Looks like we have a number of nice enhancements and bug >>> fixes in >>> >>>> >> >> >>>> Lucene and Solr for 8.10. >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> >>> https://github.com/apache/lucene-solr/blob/branch_8x/lucene/CHANGES.txt >>> >>>> >> >> >>>> >>> https://github.com/apache/lucene-solr/blob/branch_8x/solr/CHANGES.txt >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> However, there are a few open blockers marked for Solr >>> 8.10, see: >>> >>>> >> >> >>>> >>> https://issues.apache.org/jira/browse/SOLR-15596?filter=12350839 >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> The blockers (SOLR-15596, SOLR-15412, SOLR-14593) are >>> not assigned to >>> >>>> >> >> >>>> anyone. Is anyone looking at these? If not, do they need >>> to block the >>> >>>> >> >> >>>> 8.10 release? >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> I propose we should cut the release branch next week but >>> that >>> >>>> >> >> >>>> obviously depends on our decision around these open >>> blockers. >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> Cheers, >>> >>>> >> >> >>>> Timothy Potter >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> PS ~ I volunteer to be the Release Manager ;-) >>> >>>> >> >> >>>> >>> >>>> >> >> >>>> >>> --------------------------------------------------------------------- >>> >>>> >> >> >>>> To unsubscribe, e-mail: >>> dev-unsubscr...@lucene.apache.org >>> >>>> >> >> >>>> For additional commands, e-mail: >>> dev-h...@lucene.apache.org >>> >>>> >> >> >>>> >>> >>>> >> >> >>> >>> >>>> >> >> >>> >>> >>>> >> >> >>> -- >>> >>>> >> >> >>> Adrien >>> >>>> >> >> >> >>> >>>> >> >> >> -- >>> >>>> >> >> >> Mike McCandless >>> >>>> >> >> >> >>> >>>> >> >> >> http://blog.mikemccandless.com >>> >>>> >> >> >>> >>>> >> >> >>> --------------------------------------------------------------------- >>> >>>> >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> >>>> >> >> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >>>> >> >> >>> >>>> >> >>> >>>> >> >>> --------------------------------------------------------------------- >>> >>>> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> >>>> >> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >>>> >> >>> >>>> >>> >>>> >>> --------------------------------------------------------------------- >>> >>>> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org >>> >>>> For additional commands, e-mail: dev-h...@solr.apache.org >>> >>>> >>> >> -- >>> >> - Mark >>> >> >>> >> http://about.me/markrmiller >>> > >>> > -- >>> > - Mark >>> > >>> > http://about.me/markrmiller >>> >> -- >> - Mark >> >> http://about.me/markrmiller >> > -- > - Mark > > http://about.me/markrmiller > -- - Mark http://about.me/markrmiller
