The ping handler with healthcheckFile was not required for the fix, just convenient to test it manually. So I 'think we're good.
Jan > 9. nov. 2021 kl. 17:08 skrev Eric Pugh <[email protected]>: > > Would you want to keep that in the tech products, and instead migrate the > test to not use sample_techproducts_config? > > > >> On Nov 9, 2021, at 10:58 AM, Jan Høydahl <[email protected] >> <mailto:[email protected]>> wrote: >> >> Ah, that's on me. I committed a fix, see >> https://issues.apache.org/jira/browse/SOLR-10529 >> <https://issues.apache.org/jira/browse/SOLR-10529> >> >> Jan >> >>> 9. nov. 2021 kl. 14:54 skrev Eric Pugh <[email protected] >>> <mailto:[email protected]>>: >>> >>> I picked one of the hopefully simpler failures: >>> org.apache.solr.client.solrj.SolrExampleXMLTest.testPingHandler >>> >>> I then went back in time by git checkout <somecommit> and I believe it was >>> introduced by df70f902fb9a1fd2d2069641611efcdf353dc7c4, which is >>> SOLR-10529: Solr UI Health Check enable/disable ping Button doesn't work >>> >>> >>> >>> >>>> On Nov 9, 2021, at 8:34 AM, Eric Pugh <[email protected] >>>> <mailto:[email protected]>> wrote: >>>> >>>> Hi all…. Last night I merged some code >>>> (f589607e700a94544fc546f5d641b5bfd695f32b) , and then received a message >>>> from Github that the SolrJ tests had failed: >>>> https://github.com/apache/solr/actions/runs/1436978925 >>>> <https://github.com/apache/solr/actions/runs/1436978925> >>>> >>>> This morning I went to the previous commit point from >>>> f589607e700a94544fc546f5d641b5bfd695f32b and reran the tests locally: >>>> >>>> solr git:(a363acdac48) gw -p solr/solrj test >>>> >>>> Which resulted in >>>> :solr:solrj:test (FAILURE): 1705 test(s), 10 failure(s), 21 skipped >>>> >>>> >>>> So.. Do the solrj tests not run on GitHub for branches normally? Going >>>> back to my branch, that appears to be the case. Tips on what a better >>>> workflow should be for these? >>>> >>>> Secondly, are these failures typical and a known issue, or is this >>>> something where I need to revert f589607e700a94544fc546f5d641b5bfd695f32b? >>>> I remember back in the day the effort that Erick made to get all tests >>>> to pass, but I don’t remember the details as I wasn’t a committer ;-). >>>> >>>> An answer like “We know some tests fail and don’t worry about reverting >>>> your code, it’s a problem, but a long term problem” is a okay answer! >>>> >>>> Eric >>>> >>>> >>>> >>>> _______________________ >>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | >>>> http://www.opensourceconnections.com >>>> <http://www.opensourceconnections.com/> | My Free/Busy >>>> <http://tinyurl.com/eric-cal> >>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed >>>> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> >>>> >>>> This e-mail and all contents, including attachments, is considered to be >>>> Company Confidential unless explicitly stated otherwise, regardless of >>>> whether attachments are marked as such. >>>> >>> >>> _______________________ >>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | >>> http://www.opensourceconnections.com >>> <http://www.opensourceconnections.com/> | My Free/Busy >>> <http://tinyurl.com/eric-cal> >>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed >>> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> >>> >>> This e-mail and all contents, including attachments, is considered to be >>> Company Confidential unless explicitly stated otherwise, regardless of >>> whether attachments are marked as such. >>> >> > > _______________________ > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | > http://www.opensourceconnections.com <http://www.opensourceconnections.com/> > | My Free/Busy <http://tinyurl.com/eric-cal> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed > <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw> > > This e-mail and all contents, including attachments, is considered to be > Company Confidential unless explicitly stated otherwise, regardless of > whether attachments are marked as such. >
