+1 as well, I only discovered it because I saw the fixes that Mike made!
> On Jan 13, 2022, at 3:43 AM, Bruno Roustant <[email protected]> wrote:
>
> +1
> It will allow folks to try it (me included?)
>
> Bruno
>
> Le mer. 12 janv. 2022 à 17:00, Mike Drob <[email protected]
> <mailto:[email protected]>> a écrit :
> Howdy folks,
>
> After finding two quick bugs in the rate limiting code[1][2], I suspect that
> this feature has largely gone untested in our code up until now. I also
> looked at TestRequestRateLimiter and at least locally I'm getting a lot of
> EofException in the logs, which I think is unintended. This might be easy to
> fix as well, but I don't know what the next bug will be if we keep going down
> this path.
>
> I think Atri has mentioned that he was using a version of this feature with
> 8.x, but there's probably been some divergence between the two
> implementations. Maybe we can get interested folks to try it with 9.0 and
> then I have high confidence we can get it stable in time for 9.1? I do not
> think reverting the feature is necessary, and it should stay in the code.
>
> Thoughts?
> Mike
>
> [1]: https://github.com/apache/solr/pull/516
> <https://github.com/apache/solr/pull/516>
> [2]: https://github.com/apache/solr/pull/505
> <https://github.com/apache/solr/pull/505>
_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
http://www.opensourceconnections.com <http://www.opensourceconnections.com/> |
My Free/Busy <http://tinyurl.com/eric-cal>
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
<https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
This e-mail and all contents, including attachments, is considered to be
Company Confidential unless explicitly stated otherwise, regardless of whether
attachments are marked as such.
