+1 to mark as Beta or experimental. Is this a doc-only change? Jan
> 12. jan. 2022 kl. 16:59 skrev Mike Drob <[email protected]>: > > Howdy folks, > > After finding two quick bugs in the rate limiting code[1][2], I suspect that > this feature has largely gone untested in our code up until now. I also > looked at TestRequestRateLimiter and at least locally I'm getting a lot of > EofException in the logs, which I think is unintended. This might be easy to > fix as well, but I don't know what the next bug will be if we keep going down > this path. > > I think Atri has mentioned that he was using a version of this feature with > 8.x, but there's probably been some divergence between the two > implementations. Maybe we can get interested folks to try it with 9.0 and > then I have high confidence we can get it stable in time for 9.1? I do not > think reverting the feature is necessary, and it should stay in the code. > > Thoughts? > Mike > > [1]: https://github.com/apache/solr/pull/516 > <https://github.com/apache/solr/pull/516> > [2]: https://github.com/apache/solr/pull/505 > <https://github.com/apache/solr/pull/505>
