I completely understand your concern and frustration for the solrj-zookeeper PR David, it's been in the works for a while, and these refactorings are very hard on you and the contributor you are working with.
Eric and I talked, and given that there are very few giant PRs that are in progress, we agreed this work can likely continue after the solrj-zookeeper PR is merged. Going forward though, I think the strategy is going to be to attack package-by-package (addressing all issues in that package), instead of intelliJ issue by intelliJ issue (addressing all packages at the same time). That way, the PRs are confined to a specific area, so for example the solrj-zookeeper work would be unaffected unless Eric decided to tackle the solrj packages, which he could obviously postpone. I think we can all agree that the Solr codebase can be a mess, and things are not always done the way that they should be. Projects need maintenance in order to survive. I think it's great that Eric is putting in tremendous time and effort in order to improve the project in a pretty thankless way. Anyways happy to entertain further discussion on the topic, but I think the new strategy is the best compromise of moving forward without making things hard for others trying to contribute. - Houston On Sat, Jul 30, 2022 at 4:38 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > > I ask that you please suspend sweeping changes because they are a real > impediment to other branches/PRs that move lots of files. This is > happening right now: https://github.com/apache/solr/pull/943 (for SolrJ) > > +1, I don't feel the value such changes bring to the project outweigh the > disruption. > > On Fri, Jul 29, 2022 at 9:26 PM Christine Poerschke (BLOOMBERG/ LONDON) < > cpoersc...@bloomberg.net> wrote: > > > PR 916 was a subset of PR 912 and I've just resolved its conflicts. > > > > Also https://issues.apache.org/jira/browse/SOLR-16318 started, in case > > that helps. > > > > Christine > > > > From: dev@solr.apache.org At: 07/26/22 15:10:03 UTC+1:00To: > > dev@solr.apache.org > > Subject: Re: Cleaning up IntelliJ warnings in code base > > > > Not sure about https://github.com/apache/solr/pull/916 but > > https://github.com/apache/solr/pull/912 conflicts in a ton of places and > > haven't looked at updating it. > > > > Kevin Risden > > > > > > On Tue, Jul 26, 2022 at 9:51 AM Eric Pugh < > ep...@opensourceconnections.com > > > > > wrote: > > > > > Hi all…. Are there any updates to the two PR’s related to WIP about > > > updating to JDK 11 features? > > > > > > Once I’m done with https://issues.apache.org/jira/browse/SOLR-16300 < > > > https://issues.apache.org/jira/browse/SOLR-16300> Migrate from > > deprecated > > > assertThat() to org.hamcrest.MatcherAssert.assertThat(), it looks like > > MANY > > > of the remaining things to do all are related to upgrading to more > modern > > > JDK language features…. > > > > > > I’m happy to do that, but don’t want to step on the work that is > > progress? > > > > > > > > > Eric > > > > > > > On Jul 4, 2022, at 2:23 PM, Eric Pugh < > ep...@opensourceconnections.com > > > > > > wrote: > > > > > > > > I wanted to share a quick update! > > > > > > > > First off though, thanks Christine for reviewing many of the PR’s of > > > been pushing up. As I’ve been editing the files I’ve found myself > > > thinking…. WWCD in this situation[1]? > > > > > > > > Here are the PR’s that are getting close, and I’m just looking for > some > > > LGTM’s: > > > > > > > > * SOLR-16281: review boxing unboxing < > > > https://github.com/apache/solr/pull/930> > > > > * SOLR-16280: simplify for loop < > > https://github.com/apache/solr/pull/929 > > > > > > > > * SOLR-16278: remove unused declarations < > > > https://github.com/apache/solr/pull/927> > > > > * SOLR-16223: unused throws identified by IntelliJ (round 2) < > > > https://github.com/apache/solr/pull/926>. <— I learned how to use > > > IntelliJ better after doing the first round of redundant throws review > > ;-) > > > > * SOLR-16275 use standard charset instead of string forName version < > > > https://github.com/apache/solr/pull/925> > > > > * SOLR-16276: redundant variable in test < > > > https://github.com/apache/solr/pull/924> > > > > > > > > > > > > Also, as I am moving forward, I saw two PR’s that I don’t quite > > > understand, and I don’t want to step on their toes: > > > > > > > > experimental sub-set 1 of "WIP - Use up to JDK 11 features” < > > > https://github.com/apache/solr/pull/916> and WIP - Use up to JDK 11 > > > features <https://github.com/apache/solr/pull/912>, these each both > look > > > to move us up to modern Java standards across all the code…. I’m > > > wondering though if some of the work I’m doing is going to collide, > like > > > SOLR-16281? Should we prioritize one of these efforts to get to done > > > done? There appears to be a TON of great stuff in these updates to > > JDK11 > > > features, so would love to see them get in sooner versus later, and > then > > I > > > can go back to cleaning up what remains…. < > > > https://github.com/apache/solr/pull/916#partial-pull-merging> > > > > > > > > ERic > > > > > > > > <https://github.com/apache/solr/pull/912#partial-pull-merging> < > > > https://github.com/apache/solr/pull/912#partial-pull-merging> > > > > > > > > > > > > > > > > [1] WWCD: What Would Christine Do? > > > > > > > >> On Jun 27, 2022, at 5:41 PM, Eric Pugh < > > ep...@opensourceconnections.com > > > <mailto:ep...@opensourceconnections.com>> wrote: > > > >> > > > >> I pushed up some more PR’s for warnings from IntelliJ. > > > >> > > > >> Here are the ones that if folks agree, are ready for merging. > > > >> > > > >> * SOLR-162680: toString is not required when crafting a string > > message < > > > https://github.com/apache/solr/pull/922> > > > >> * SOLR-16224: class level variables that can be safely made local, > and > > > are boilerpl… <https://github.com/apache/solr/pull/921> > > > >> * SOLR-16269 clean up use of final keyword < > > > https://github.com/apache/solr/pull/919> > > > >> * SOLR-16270: address dangling javadocs < > > > https://github.com/apache/solr/pull/918> > > > >> > > > >> Another one that I am looking at is to eliminate all of the import > > > java.util.*; type imports, which I believe is what we have in the main > > > code base. I wanted to make sure that is a pattern to follow in the > unit > > > tests too? > > > >> > > > >> SOLR-16271: clean up imports (WIP) < > > > https://github.com/apache/solr/pull/920> > > > >> > > > >> Eric > > > >> > > > >> <https://github.com/apache/solr/pull/918#partial-pull-merging> < > > > https://github.com/apache/solr/pull/918#partial-pull-merging> > > > >> <https://github.com/apache/solr/pull/919#partial-pull-merging> < > > > https://github.com/apache/solr/pull/919#partial-pull-merging> > > > >> <https://github.com/apache/solr/pull/921#partial-pull-merging> < > > > https://github.com/apache/solr/pull/921#partial-pull-merging> > > > >> <https://github.com/apache/solr/pull/922#partial-pull-merging> < > > > https://github.com/apache/solr/pull/922#partial-pull-merging> > > > >> > > > >>> On Jun 27, 2022, at 11:25 AM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>> > > > >>> Thanks David for the comments in the ticket, and it makes sense to > > > treat stylistic warnings different from deprecations. > > > >>> > > > >>> > > > >>> > > > >>>> On Jun 24, 2022, at 10:11 PM, David Smiley <dsmi...@apache.org > > > <mailto:dsmi...@apache.org>> wrote: > > > >>>> > > > >>>> How to handle certain deprecations is IMO a different matter than > > > stylistic-ish warnings. I'll respond in SOLR-16263. > > > >>>> > > > >>>> ~ David Smiley > > > >>>> Apache Lucene/Solr Search Developer > > > >>>> http://www.linkedin.com/in/davidwsmiley < > > > http://www.linkedin.com/in/davidwsmiley> > > > >>>> > > > >>>> On Fri, Jun 24, 2022 at 12:19 PM Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>> I created https://issues.apache.org/jira/browse/SOLR-16263 < > > > https://issues.apache.org/jira/browse/SOLR-16263>, "Migrate tests from > > > deprecate http clients to http2 equivalents”. I wanted to confirm > that > > > we ARE actually deprecating and removing HttpSolrClient in favour of > > > Http2SolrClient ??? > > > >>>> > > > >>>> Since it was deprecated in 9.0, what does that mean for updating > the > > > tests? They can only be updated to Http2SolrClient in the main > branch? > > > Or can the tests at least be updated to Http2SolrClient in main and > > > branch_9x? > > > >>>> > > > >>>> > > > >>>> > > > >>>>> On Jun 24, 2022, at 10:10 AM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>> > > > >>>>> I wanted to send a heads up that I plan on merging > > > https://github.com/apache/solr/pull/900 < > > > https://github.com/apache/solr/pull/900> on Monday as I’ll be back > > > online, starting the long drive back home to Virginia. > > > >>>>> > > > >>>>> > > > >>>>> > > > >>>>>> On Jun 13, 2022, at 5:10 PM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>> > > > >>>>>> Made it to Kansas ;-). Tomorrow I’ll have an hour before I > sign > > > off for two weeks of vacation time in Colorado.... Is it too risky to > > > merge this to main? I was thinking that keeping this patch up to date > > > would be very difficult with ongoing changes, but now rethinking that…. > > > >>>>>> > > > >>>>>> Eric > > > >>>>>> > > > >>>>>> > > > >>>>>>> On Jun 13, 2022, at 9:50 AM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>> > > > >>>>>>> Thanks Christine for putting in some suggestions! I’m passing > > > through Saline MO (https://goo.gl/maps/cZGCTZy5aN8UHNo8A < > > > > > > > > https://www.google.com/maps/place/Saline,+MI+48176/@42.1765171,-83.7954921,14z/d > > > > > ata=!3m1!4b1!4m5!3m4!1s0x883cbacfff5b8a61:0xb76c9793c1fef3cd!8m2!3d42.1667072!4d > > -83.7816075 > > < > https://www.google.com/maps/place/Saline,+MI+48176/@42.1765171,-83.7954921,14z/data=!3m1!4b1!4m5!3m4!1s0x883cbacfff5b8a61:0xb76c9793c1fef3cd!8m2!3d42.1667072!4d-83.7816075 > > > > >) > > > and just finished my pass through all the solr/core/src/test-files. > I’m > > > checking out the suggestions you made. > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> > > > >>>>>>>> On Jun 12, 2022, at 4:44 PM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>>> > > > >>>>>>>> While sitting in the car from Virginia to Missouri I have been > > > fixing up typos and grammar. > > > >>>>>>>> > > > >>>>>>>> https://github.com/apache/solr/pull/900 < > > > https://github.com/apache/solr/pull/900> > > > >>>>>>>> Tomorrow on the way to Kansas I will finish up the last few > > tests. > > > >>>>>>>> > > > >>>>>>>> I would love to get some review.... my thought is if any of > > the > > > changes I made don’t seem right I will back them out. Erik Hatcher > gave > > me > > > one example, the use of the word collocated versus colated. > > > >>>>>>>> > > > >>>>>>>> I would love to merge this on Tuesday on my way to Colorado. > > > >>>>>>>> > > > >>>>>>>> On Thu, Jun 9, 2022 at 4:40 PM Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>>> Thanks Mike for fixing my backport issue…… > > > >>>>>>>> > > > >>>>>>>> So, I’ve wended my way through 84 files focusing on grammar > and > > > typos: https://github.com/apache/solr/pull/900 < > > > https://github.com/apache/solr/pull/900> > > > >>>>>>>> > > > >>>>>>>> One thing I wanted to highlight, the > > > AffinityPlacementFactory.java < > > > > > > > > https://github.com/apache/solr/pull/900/files#diff-660c049913f52a982b864a41bc795 > > b5803c9f72bfa17ef1efcf72eb9e2354b5f > > < > https://github.com/apache/solr/pull/900/files#diff-660c049913f52a982b864a41bc795b5803c9f72bfa17ef1efcf72eb9e2354b5f > > > > > > > > has a typo in the Exception message. I fixed it, but wondered if > there > > > was potentially some small chance that the original spelling is > important > > > for some reason? > > > >>>>>>>> > > > >>>>>>>> I’d love a thumbs up that I’m going in the right direction, > I’ll > > > probably pick this up again on Saturday…. > > > >>>>>>>> > > > >>>>>>>> > > > >>>>>>>> Eric > > > >>>>>>>> > > > >>>>>>>>> On Jun 3, 2022, at 4:52 PM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>>>> > > > >>>>>>>>> Okay, I merged the other day…. > > > >>>>>>>>> > > > >>>>>>>>> Firstly, in terms of a workflow, I looked at the > > > Solr-NightlyTests-main Jenkins test, and in fact the one that ran after > > my > > > commit has two tests that failed that look like normal build failures…. > > > Versus what I committed: > > > > > > > > https://ci-builds.apache.org/job/Solr/job/Solr-NightlyTests-main/445/#showFailur > > esLink > > > < > > > > > > > > https://ci-builds.apache.org/job/Solr/job/Solr-NightlyTests-main/445/#showFailur > > esLink > > > > > > > >>>>>>>>> > > > >>>>>>>>> Are there any other Jenkin’s builds I should keep an eye on? > > > >>>>>>>>> > > > >>>>>>>>> Secondly, what is the Jenkins Test Failure Report that I > should > > > keep an eye on? I’ve seen > > > http://fucit.org/solr-jenkins-reports/failure-report.html < > > > http://fucit.org/solr-jenkins-reports/failure-report.html> in the > past, > > > and is this the one we want? It looks like this report aggregates > from > > > MANY different Jenkins jobs, so I would be looking for a failure that > > > starts up post my commit? Or, do you recommend that I focus on > > > > > > http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html > > > < > > > > > > http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html > > > > > > ??/ > > > >>>>>>>>> > > > >>>>>>>>> Lastly, give it say 5 days and then back port to branch_9x??? > > > >>>>>>>>> > > > >>>>>>>>> Thanks! > > > >>>>>>>>> > > > >>>>>>>>> Eric > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>>> On Jun 1, 2022, at 8:11 AM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>>>>> > > > >>>>>>>>>> One last question…. “Squash and Merge” right? We don’t > care > > > about all my interim commits…. > > > >>>>>>>>>> > > > >>>>>>>>>>> On May 31, 2022, at 6:37 PM, Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>>>>>> > > > >>>>>>>>>>> Cool. > > > >>>>>>>>>>> > > > >>>>>>>>>>> So here is an example of what I’ll merge in a day or so: > > > https://github.com/apache/solr/pull/885 < > > > https://github.com/apache/solr/pull/885> > > > >>>>>>>>>>> > > > >>>>>>>>>>> And I’m going to start on a new PR for > > > https://issues.apache.org/jira/browse/SOLR-16224 < > > > https://issues.apache.org/jira/browse/SOLR-16224> that is about > looking > > > at how fields are defined in the tests. > > > >>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>>> On May 31, 2022, at 12:41 PM, Houston Putman < > > > hous...@apache.org <mailto:hous...@apache.org>> wrote: > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> What about back porting, would you want these back ported > to > > > 8 and 9? Or just 9? > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> I would say just main and branch_9x > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> On Tue, May 31, 2022 at 12:39 PM Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>>>>>>> Thanks for the response Mike… > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> So I finished up going through the test code, and yeah, > > > wow…. Doing it one file at a time was educational at least ;-). > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > > > > > > https://github.com/apache/solr/compare/main...epugh:intellij_inspired_cleanups?e > > xpand=1 > > < > https://github.com/apache/solr/compare/main...epugh:intellij_inspired_cleanups?expand=1 > > > > > < > > > > > > > > https://github.com/apache/solr/compare/main...epugh:intellij_inspired_cleanups?e > > xpand=1 > > < > https://github.com/apache/solr/compare/main...epugh:intellij_inspired_cleanups?expand=1 > > > > > > > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> In terms of a workflow, should I open up a single JIRA and > > > then list under it a task for each type of fix? And then merge each > > > individual type of fix? > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> So a single JIRA issue “Examine IntelliJ Warnings in Test > > > Code”, and then a JIRA under that for each type, starting with “Remove > > > Exceptions not thrown by Method”? Then merge each one to main, wait a > > few > > > days to make sure no spike in errors, and then do the next one? > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> What about back porting, would you want these back ported > to > > > 8 and 9? Or just 9? > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> Eric > > > >>>>>>>>>>>> > > > >>>>>>>>>>>>> On May 27, 2022, at 8:50 PM, Mike Drob <md...@mdrob.com > > > <mailto:md...@mdrob.com>> wrote: > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> Declaring an unused thrown exception in tests isn't the > > most > > > critical change, but cleaning this up might help us discover accidental > > API > > > signature changes in the future. If a test throws an exception then > JUnit > > > will figure it out and fail the test anyway, which is probably what we > > want > > > to do regardless. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> I'm +0 on this, like I am not going to go out of my way > to > > > refactor that, but now that you've done it I don't want to just throw > > away > > > your work so it's probably fine to commit. I hope this was some > automated > > > fix you could apply instead of doing manually. > > > >>>>>>>>>>>>> But I'm also not going to review it, so I hope you trust > > the > > > automated tooling and are willing to volunteer watching Jenkins for a > few > > > days after. :) > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> Unused exceptions anywhere under src/main I would be > _very_ > > > interested in, on the other hand. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> Mike > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> On Fri, May 27, 2022 at 7:33 PM Eric Pugh < > > > ep...@opensourceconnections.com <mailto: > ep...@opensourceconnections.com > > >> > > > wrote: > > > >>>>>>>>>>>>> So, going through and cleaning up unused throwing of > > > exceptions, I’ve touched all these files listed below. I was > thinking I > > > would do ONE commit for all of the “remove unused Exception”…. > Before I > > > keep going, wanted to make sure that makes sense….. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/analysis/CommonGramsPhraseQueryTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/analysis/PathHierarchyTokenizerFactoryTest.ja > > va > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/analysis/TestLuceneMatchVersion.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/analysis/TestReversedWildcardFilterFactory.ja > > va > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/analysis/TokenizerChainTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/ActionThrottleTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/cloud/AssignBackwardCompatibilityTest.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/CollectionPropsTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/cloud/ConcurrentCreateRoutedAliasTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/ConfigSetApiLockingTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/CreateRoutedAliasTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/cloud/DistribJoinFromCollectionTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/LeaderElectionTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/OverseerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/ReindexCollectionTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/SolrCLIZkUtilsTest.java > > > >>>>>>>>>>>>> modified: > > > > > solr/core/src/test/org/apache/solr/cloud/TestAuthenticationFramework.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestBaseStatsCacheCloud.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestCloudDeleteByQuery.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestCloudInspectUtil.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestCloudPivotFacet.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestHashPartitioner.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestPrepRecovery.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestSSLRandomization.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/TestStressCloudBlindAtomicUpdates.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/TestTlogReplica.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/cloud/ZkCLITest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/api/collections/AsyncCallRequestStatusR > > esponseTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/api/collections/BackupRestoreApiErrorCo > > nditionsTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/api/collections/CollectionApiLockingTes > > t.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/api/collections/CollectionTooManyReplic > > asTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/api/collections/ReplicaPropertiesBase.j > > ava > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/api/collections/TestLocalFSCloudBackupR > > estore.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cloud/api/collections/TestReplicaProperties.j > > ava > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/cluster/events/impl/CollectionsRepairEventLis > > tenerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/AlternateDirectoryTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/DirectoryFactoryTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/HelloStream.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/ResourceLoaderTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/SOLR749Test.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/SolrCoreTest.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/core/TestBackupRepositoryFactory.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/TestCodecSupport.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/TestConfig.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/TestConfigSetImmutable.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/TestConfigSetProperties.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/TestConfigSets.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/TestShardHandlerFactory.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/core/TestXIncludeConfig.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/core/snapshots/TestSolrCloudSnapshots.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/core/snapshots/TestSolrCoreSnapshots.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/DocumentAnalysisRequestHandlerTest.ja > > va > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/FieldAnalysisRequestHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/handler/MoreLikeThisHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/PingRequestHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/SearchHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java > > > >>>>>>>>>>>>> modified: > > > > > solr/core/src/test/org/apache/solr/handler/TestIncrementalCoreBackup.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/TestSnapshotCoreBackup.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/TestSolrConfigHandlerCloud.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/V2ApiIntegrationTest.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/handler/V2ClusterAPIMappingTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/V2UpdateAPIMappingTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/XmlUpdateRequestHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/admin/CoreAdminOperationTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/CoreMergeIndexesAdminHandlerTes > > t.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/admin/HealthCheckHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/admin/IndexSizeEstimatorTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/admin/LukeRequestHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/ShowFileRequestHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/admin/SplitHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > > > solr/core/src/test/org/apache/solr/handler/admin/StatsReloadRaceTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/admin/SystemInfoHandlerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/handler/admin/TestApiFramework.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/handler/admin/TestCollectionAPIs.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/V2CollectionBackupsAPIMappingTe > > st.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/V2CollectionsAPIMappingTest.jav > > a > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest. > > java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/api/V2CoreAPIMappingTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/api/V2NodeAPIMappingTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/admin/api/V2ShardsAPIMappingTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/component/BadComponentTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/CustomHighlightComponentTes > > t.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/DistributedExpandComponentT > > est.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/DistributedFacetExistsSmall > > Test.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/DistributedSpellCheckCompon > > entTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/DistributedSuggestComponent > > Test.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/component/FacetPivotSmallTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/component/ShardRequestTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/SpellCheckComponentTest.jav > > a > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/SuggestComponentContextFilt > > erQueryTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/SuggestComponentTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/component/TestExpandComponent.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/component/TestHttpShardHandlerFactory > > .java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/component/TestPivotHelperCode.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/handler/loader/JavabinLoaderTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/handler/tagger/EmbeddedSolrNoSerializeTest.ja > > va > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/handler/tagger/XmlInterpolationTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/highlight/DummyHighlighter.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/highlight/HighlighterMaxOffsetTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/highlight/HighlighterTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/internal/csv/CharBufferTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/legacy/TestLegacyField.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/legacy/TestLegacyNumericUtils.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/metrics/JvmMetricsTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/metrics/MetricsConfigTest.java > > > >>>>>>>>>>>>> modified: > > > > > solr/core/src/test/org/apache/solr/metrics/SolrCoreMetricManagerTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/metrics/SolrMetricManagerTest.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/metrics/reporters/SolrJmxReporterTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/metrics/reporters/SolrSlf4jReporterTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/request/TestFaceting.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/response/TestJavabinTupleStreamParser.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/response/TestRawResponseWriter.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/response/TestRetrieveFieldsOptimizer.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/response/TestSolrQueryResponse.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformer.ja > > va > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHie > > rarchy.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/response/transform/TestExplainDocTransformer. > > java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformer.ja > > va > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerCro > > ssCore.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/rest/TestManagedResource.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/rest/TestRestManager.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestDynamicFieldCollectionResourc > > e.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestDynamicFieldResource.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestFieldCollectionResource.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/rest/schema/TestFieldResource.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestFieldTypeCollectionResource.j > > ava > > > >>>>>>>>>>>>> modified: > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestFieldTypeResource.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestSchemaNameResource.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/rest/schema/TestSchemaResource.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestSchemaSimilarityResource.java > > > >>>>>>>>>>>>> modified: > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestSchemaVersionResource.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestSerializedLuceneMatchVersion. > > java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/rest/schema/TestUniqueKeyFieldResource.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/CurrencyFieldTypeTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/DocValuesMultiTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/EnumFieldTest.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/schema/ExternalFileFieldSortTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/IndexSchemaTest.java > > > >>>>>>>>>>>>> modified: > > > > > > > > solr/core/src/test/org/apache/solr/schema/ManagedSchemaRoundRobinCloudTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/PolyFieldTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/PreAnalyzedFieldTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/RankFieldTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/SchemaWatcherTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/SpatialRPTFieldTypeTest.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/TestCloudManagedSchema.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/TestManagedSchema.java > > > >>>>>>>>>>>>> modified: > > > solr/core/src/test/org/apache/solr/schema/TestSortableTextField.java > > > >>>>>>>>>>>>> modified: > > > > solr/core/src/test/org/apache/solr/schema/TestUseDocValuesAsStored.java > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>>> On May 27, 2022, at 1:52 PM, David Smiley < > > > dsmi...@apache.org <mailto:dsmi...@apache.org>> wrote: > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> IntelliJ is produced by a company and I have no idea how > > > they go about selecting what the default inspections (what IntelliJ > calls > > > these) are. Maybe it was one person there, maybe it was arbitrary by > > > whoever wrote the inspection, or maybe they had some more thoughtful > > > approach that looked at literature. Regardless, I disagree with some > of > > > their choices. I think we should base our decisions on what > inspections > > to > > > address for ourselves, not just because JetBrains included them. I > > > routinely adjust my IntelliJ inspection settings to not harass me about > > > some matters that I consider to be frivolous. For example boolean > > > expression simplifications -- where we as a project (when a part of > > Lucene) > > > have chosen "== false" to be clearer than an exclamation point adjacent > > to > > > a boolean expression. > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> If we do some of this: Agreed on picking exactly one > > > "inspection" and scoping to just one module at first. Could increase > to > > > more commits in the same PR if you get good feedback. > > > >>>>>>>>>>>>>> Personally, I wouldn't do this endeavor unless the > > > particular inspection is something that particularly motivates me / > was a > > > pet-peeve. > > > >>>>>>>>>>>>>> I think "getting to green" is a toal lost cause unless > we > > > were to enforce a particular configured list of inspections (which is > > > IntelliJ only, remember). > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> ~ David Smiley > > > >>>>>>>>>>>>>> Apache Lucene/Solr Search Developer > > > >>>>>>>>>>>>>> http://www.linkedin.com/in/davidwsmiley < > > > http://www.linkedin.com/in/davidwsmiley> > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> On Fri, May 27, 2022 at 12:52 PM Shawn Heisey < > > > apa...@elyograg.org <mailto:apa...@elyograg.org>> wrote: > > > >>>>>>>>>>>>>> On 5/27/2022 8:24 AM, Eric Pugh wrote: > > > >>>>>>>>>>>>>> > Hey all, was poking around at a unit test while > watching > > > TV and > > > >>>>>>>>>>>>>> > noticed lots of warnings from IntelliJ, little stuff > > like > > > exceptions > > > >>>>>>>>>>>>>> > being thrown that don’t need to be thrown, unused > > > variables, or typos. > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> In eclipse, there are THOUSANDS of warnings. And last I > > > checked, even a > > > >>>>>>>>>>>>>> bunch of errors. But I was able to build > 10.0.0-SNAPSHOT > > > successfully. > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> Thanks, > > > >>>>>>>>>>>>>> Shawn > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> > > > --------------------------------------------------------------------- > > > >>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > > > <mailto:dev-unsubscr...@solr.apache.org> > > > >>>>>>>>>>>>>> For additional commands, e-mail: > dev-h...@solr.apache.org > > > <mailto:dev-h...@solr.apache.org> > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> _______________________ > > > >>>>>>>>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>>>>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>>>>>>>>> This e-mail and all contents, including attachments, is > > > considered to be Company Confidential unless explicitly stated > otherwise, > > > regardless of whether attachments are marked as such. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> _______________________ > > > >>>>>>>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>>>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>>>>>>>> This e-mail and all contents, including attachments, is > > > considered to be Company Confidential unless explicitly stated > otherwise, > > > regardless of whether attachments are marked as such. > > > >>>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>> _______________________ > > > >>>>>>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>>>>>>> This e-mail and all contents, including attachments, is > > > considered to be Company Confidential unless explicitly stated > otherwise, > > > regardless of whether attachments are marked as such. > > > >>>>>>>>>>> > > > >>>>>>>>>> > > > >>>>>>>>>> _______________________ > > > >>>>>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>>>>>> This e-mail and all contents, including attachments, is > > > considered to be Company Confidential unless explicitly stated > otherwise, > > > regardless of whether attachments are marked as such. > > > >>>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>> _______________________ > > > >>>>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>>>>> This e-mail and all contents, including attachments, is > > > considered to be Company Confidential unless explicitly stated > otherwise, > > > regardless of whether attachments are marked as such. > > > >>>>>>>>> > > > >>>>>>>> > > > >>>>>>>> _______________________ > > > >>>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>>>> This e-mail and all contents, including attachments, is > > > considered to be Company Confidential unless explicitly stated > otherwise, > > > regardless of whether attachments are marked as such. > > > >>>>>>>> > > > >>>>>>> > > > >>>>>>> _______________________ > > > >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>>> This e-mail and all contents, including attachments, is > > considered > > > to be Company Confidential unless explicitly stated otherwise, > regardless > > > of whether attachments are marked as such. > > > >>>>>>> > > > >>>>>> > > > >>>>>> _______________________ > > > >>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>>> This e-mail and all contents, including attachments, is > considered > > > to be Company Confidential unless explicitly stated otherwise, > regardless > > > of whether attachments are marked as such. > > > >>>>>> > > > >>>>> > > > >>>>> _______________________ > > > >>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>>> This e-mail and all contents, including attachments, is > considered > > > to be Company Confidential unless explicitly stated otherwise, > regardless > > > of whether attachments are marked as such. > > > >>>>> > > > >>>> > > > >>>> _______________________ > > > >>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > > 434.466.1467 | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>>> This e-mail and all contents, including attachments, is considered > > to > > > be Company Confidential unless explicitly stated otherwise, regardless > of > > > whether attachments are marked as such. > > > >>>> > > > >>> > > > >>> _______________________ > > > >>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > > 434.466.1467 > > > | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >>> This e-mail and all contents, including attachments, is considered > to > > > be Company Confidential unless explicitly stated otherwise, regardless > of > > > whether attachments are marked as such. > > > >>> > > > >> > > > >> _______________________ > > > >> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > 434.466.1467 > > > | http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > >> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > >> This e-mail and all contents, including attachments, is considered > to > > > be Company Confidential unless explicitly stated otherwise, regardless > of > > > whether attachments are marked as such. > > > >> > > > > > > > > _______________________ > > > > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | > 434.466.1467 > > | > > > http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > > This e-mail and all contents, including attachments, is considered to > > be > > > Company Confidential unless explicitly stated otherwise, regardless of > > > whether attachments are marked as such. > > > > > > > > > > _______________________ > > > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 > | > > > http://www.opensourceconnections.com < > > > http://www.opensourceconnections.com/> | My Free/Busy < > > > http://tinyurl.com/eric-cal> > > > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed < > > > > > > > > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterpri > > se-search-server-third-edition-raw > > < > https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw > > > > > > > > > > > This e-mail and all contents, including attachments, is considered to > be > > > Company Confidential unless explicitly stated otherwise, regardless of > > > whether attachments are marked as such. > > > > > > > > > > > > >
