Resending with corrected email address On Wed, Aug 23, 2023 at 11:13 AM Mike Drob <md...@mdrob.com> wrote:
> Hi Isabelle, > > It looks like there is a precommit check issue with the code still, can > you take a look and address that? You should be able to click on > "details" for the failing check, or run it locally using ./gradlew check > -x test > > Thanks for your contribution! > > On Wed, Aug 23, 2023 at 9:52 AM Isabelle Giguere > <igigu...@opentext.com.invalid> wrote: > >> Hello Solr committers! >> >> This PR was reviewed by Christine Poerschke<https://github.com/cpoerschke> >> and Alex D<https://github.com/stillalex>. Thank you both 🙂 >> >> IMHO, the code is as clean as it's going to get. I hope it can be merged >> some day. >> >> https://github.com/apache/solr/pull/1632 >> >> Regards; >> >> Isabelle Giguère >> >>