Hi Mike; Thanks for the heads-up.
Task "validateSourcePatterns" fails if there's no logger specific to the test class! I'll fix that... But... Should "validateSourcePatterns" be so picky about logging in test classes? Just a thought. Isabelle Giguère ________________________________ De : Mike Drob <md...@mdrob.com> Envoyé : 23 août 2023 12:14 À : Isabelle Giguere <igigu...@opentext.com> Cc : dev solr <dev@solr.apache.org> Objet : [EXTERNAL] - Re: PR reviewed CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you feel that the email is suspicious, please report it using PhishAlarm. Resending with corrected email address On Wed, Aug 23, 2023 at 11:13 AM Mike Drob <md...@mdrob.com<mailto:md...@mdrob.com>> wrote: Hi Isabelle, It looks like there is a precommit check issue with the code still, can you take a look and address that? You should be able to click on "details" for the failing check, or run it locally using ./gradlew check -x test Thanks for your contribution! On Wed, Aug 23, 2023 at 9:52 AM Isabelle Giguere <igigu...@opentext.com.invalid> wrote: Hello Solr committers! This PR was reviewed by Christine Poerschke<https://github.com/cpoerschke<https://urldefense.com/v3/__https://github.com/cpoerschke__;!!Obbck6kTJA!apdgjI2Vf7UM6mj_LfBCJLMlYsIQTv5AmJN5uV6Jp8Bw9pO7Uw8kGnMJtHAmpjWqSaPV3UHSzhcbBw$>> and Alex D<https://github.com/stillalex<https://urldefense.com/v3/__https://github.com/stillalex__;!!Obbck6kTJA!apdgjI2Vf7UM6mj_LfBCJLMlYsIQTv5AmJN5uV6Jp8Bw9pO7Uw8kGnMJtHAmpjWqSaPV3UHitnUfYw$>>. Thank you both 🙂 IMHO, the code is as clean as it's going to get. I hope it can be merged some day. https://github.com/apache/solr/pull/1632<https://urldefense.com/v3/__https://github.com/apache/solr/pull/1632__;!!Obbck6kTJA!apdgjI2Vf7UM6mj_LfBCJLMlYsIQTv5AmJN5uV6Jp8Bw9pO7Uw8kGnMJtHAmpjWqSaPV3UHpLPkKqA$> Regards; Isabelle Giguère
