+1 to the one line change from info to dbg On 11/20/2019 1:29 PM, Giovanni Bechis wrote: > On Wed, Nov 20, 2019 at 12:14:18PM -0500, Noah Meyerhans wrote: >> On Sat, Nov 09, 2019 at 02:20:15AM -0500, Kevin A. McGrail wrote: >>> 3.4.3 release candidate 6 is now available at >>> http://talon2.pccc.com/~kmcgrail/devel/ or >>> http://people.apache.org/~kmcgrail/devel/ >>> >>> PLEASE NOTE: One of the hold-ups for releasing 3.4.3 has been finding >>> little bugs while testing new features. As such, we could really use >>> some people testing the release candidates. I am running these release >>> candidates in production and have no reservations recommending the same. >> I uploaded 3.4.3-rc6 to Debian testing and unstable. Hopefully this >> gets a little more test exposure, though I don't know that there are >> many people using these distro branches as part of their mail >> infrastructure. I'll pass along anything I do hear, though. >> >> I'm also running rc6 on my mail gateway. >> >> The only thing I've noticed so far is the appearance of logs such as the >> one below. This was discussed briefly in >> https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7033, in the context >> of 3.4.0, but was not seen as an issue. However, something has >> definitely changed with 3.4.3(-rc6). I never saw these messages on my >> mail host with previous versions of spamassassin (literally zero >> occurrences in years), but I see dozens of them daily with 3.4.3. I >> have not changed any other dependencies on this host. >> >> Nov 20 09:54:53 amarth spamd[3976]: dns: no callback for id >> 55444/IN/A/99.29.145.198.dnsbl.sorbs.net, ignored; packet: ;; Response >> received from 127.0.0.1 (58 octets) >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; HEADER SECTION >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; id = 55444 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qr = 1 aa = 0 tc = 0 rd = >> 1 opcode = QUERY >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ra = 1 z = 0 ad = 0 cd = 0 >> rcode = SERVFAIL >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; qdcount = 1 ancount = 0 >> nscount = 0 arcount = 1 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; do = 0 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option: >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; QUESTION SECTION (1 record) >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; >> 99.29.145.198.dnsbl.sorbs.net. IN A >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ANSWER SECTION (0 records) >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; AUTHORITY SECTION (0 >> records) >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; ADDITIONAL SECTION (1 >> record) >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; EDNS version 0 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; flags: 0000 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; rcode: NOERROR >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; size: 4096 >> Nov 20 09:54:53 amarth spamd[3976]: dns: [...] ;; option: >> Nov 20 09:54:53 amarth spamd[3976]: dns: no likely matching queries for id >> 55444 >> >> I haven't looked deeply into what has changed. IMO logging something >> when DNS returns a SERVFAIL makes sense, but this level of detail should >> probably be reserved for debug severity. >> > anybody against this diff ? > > Giovanni > > Index: lib/Mail/SpamAssassin/DnsResolver.pm > =================================================================== > --- lib/Mail/SpamAssassin/DnsResolver.pm (revision 1870052) > +++ lib/Mail/SpamAssassin/DnsResolver.pm (working copy) > @@ -858,7 +858,7 @@ > if ($rcode eq 'REFUSED' || $id =~ m{^\d+/NO_QUESTION_IN_PACKET\z}) > { > # the failure was already reported above > } else { > - info("dns: no callback for id %s, ignored; packet: %s", > + dbg("dns: no callback for id %s, ignored; packet: %s", > $id, $packet ? $packet->string : "undef" ); > } > # report a likely matching query for diagnostic purposes
-- Kevin A. McGrail [email protected] Member, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171
