Fyi the main problem is old DNS answers getting around there SA already finished. Fixed this in trunk a while ago along with some other cleanups. I don't see it necessary for 3.4.3, been too many delays already, it's mainly cosmetic.
https://svn.apache.org/viewvc?view=revision&revision=1866126 On Wed, Nov 20, 2019 at 01:45:01PM -0500, Bill Cole wrote: > +1 for this. Noting the problem at 'info' is good. > > > On 20 Nov 2019, at 13:41, Henrik K wrote: > > >On Wed, Nov 20, 2019 at 07:29:10PM +0100, Giovanni Bechis wrote: > >>anybody against this diff ? > >> > >> Giovanni > >> > >>Index: lib/Mail/SpamAssassin/DnsResolver.pm > >>=================================================================== > >>--- lib/Mail/SpamAssassin/DnsResolver.pm (revision 1870052) > >>+++ lib/Mail/SpamAssassin/DnsResolver.pm (working copy) > >>@@ -858,7 +858,7 @@ > >> if ($rcode eq 'REFUSED' || $id =~ > >>m{^\d+/NO_QUESTION_IN_PACKET\z}) { > >> # the failure was already reported above > >> } else { > >>- info("dns: no callback for id %s, ignored; packet: %s", > >>+ dbg("dns: no callback for id %s, ignored; packet: %s", > >> $id, $packet ? $packet->string : "undef" ); > >> } > >> # report a likely matching query for diagnostic purposes > > > >If you would check trunk it's already there. Please use the same code for > >uniformity. > > > > info("dns: no callback for id $id, ignored, packet on next > >debug line"); > > # prevent filling normal logs with huge packet dumps > > dbg("dns: %s", $packet ? $packet->string : "undef"); > > > -- > Bill Cole > [email protected] or [email protected] > (AKA @grumpybozo and many *@billmail.scconsult.com addresses) > Not Currently Available For Hire
