Yeah, I am +1 for including Kafka 0.10 integration as well. We had to wait for Kafka 0.10 because there were incompatibilities between the Kafka 0.9 and 0.10 API. And, yes, the code for 0.8.0 remains unchanged so there shouldn't be any regression for existing users. It's only new code for 0.10.
The comments about python support lacking are correct but I do think it's unfair to unblock this particular PR, without a wider policy of blocking every PR on that. On Wed, Jun 22, 2016 at 9:01 AM, Chris Fregly <ch...@fregly.com> wrote: > +1 for 0.10 support. this is huge. > > On Wed, Jun 22, 2016 at 8:17 AM, Cody Koeninger <c...@koeninger.org> > wrote: > >> Luciano knows there are publicly available examples of how to use the >> 0.10 connector, including TLS support, because he asked me about it >> and I gave him a link >> >> >> https://github.com/koeninger/kafka-exactly-once/blob/kafka-0.9/src/main/scala/example/TlsStream.scala >> >> If any committer at any time had said "I'd accept this PR, if only it >> included X", I'd be happy to provide X. Documentation updates and >> python support for the 0.8 direct stream connector were done after the >> original PR. >> >> >> >> On Wed, Jun 22, 2016 at 9:55 AM, Luciano Resende <luckbr1...@gmail.com> >> wrote: >> > >> > >> > On Wed, Jun 22, 2016 at 7:46 AM, Cody Koeninger <c...@koeninger.org> >> wrote: >> >> >> >> As far as I know the only thing blocking it at this point is lack of >> >> committer review / approval. >> >> >> >> It's technically adding a new feature after spark code-freeze, but it >> >> doesn't change existing code, and the kafka project didn't release >> >> 0.10 until the end of may. >> >> >> > >> > >> > To be fair with the Kafka 0.10 PR assessment : >> > >> > I was expecting somewhat an easy transition from customer using 0.80 to >> 0.10 >> > connector, but the 0.10 seems to have been treated as a completely new >> > extension, also, there is no python support, no samples on the pr >> > demonstrating how to use security capabilities and no documentation >> updates. >> > >> > Thanks >> > >> > -- >> > Luciano Resende >> > http://twitter.com/lresende1975 >> > http://lresende.blogspot.com/ >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org >> For additional commands, e-mail: dev-h...@spark.apache.org >> >> > > > -- > *Chris Fregly* > Research Scientist @ PipelineIO > San Francisco, CA > pipeline.io > advancedspark.com > >
