I see. Thanks. I was wondering if I can see the configuration file since that looks needed (https://github.com/holdenk/mention-bot#configuration) but I couldn't find (sorry if it's just something I simply missed).
2018년 7월 31일 (화) 오전 1:48, Holden Karau <hol...@pigscanfly.ca>님이 작성: > So the one that is running is the the form in my own repo (set up for K8s > deployment) - http://github.com/holdenk/mention-bot > > On Mon, Jul 30, 2018 at 3:15 AM Hyukjin Kwon <gurwls...@gmail.com> wrote: > >> Holden, so, is it a fork in >> https://github.com/facebookarchive/mention-bot? Would you mind if I ask >> where I can see the configurations for it? >> >> >> 2018년 7월 23일 (월) 오전 10:16, Holden Karau <hol...@pigscanfly.ca>님이 작성: >> >>> Yeah so the issue with codeowners is it will only assign to committers >>> on the repo (the Beam project found this out the practical application way). >>> >>> I have a fork of mention bot running and it seems we can add it (need an >>> infra ticket), but one of the things the Beam folks asked was to not ping >>> code authors who haven’t committed in the past year which I need to do a >>> bit of poking on to make happen. >>> >>> On Sun, Jul 22, 2018 at 7:04 PM Nicholas Chammas < >>> nicholas.cham...@gmail.com> wrote: >>> >>>> On this topic, I just stumbled on a GitHub feature called CODEOWNERS >>>> <https://help.github.com/articles/about-codeowners/>. It lets you >>>> specify owners of specific areas of the repository using the same syntax >>>> that .gitignore uses. Here is CPython's CODEOWNERS file >>>> <https://github.com/python/cpython/blob/master/.github/CODEOWNERS> for >>>> reference. >>>> >>>> Dunno if that would complement mention-bot (which Facebook is >>>> apparently no longer maintaining >>>> <https://github.com/facebookarchive/mention-bot#readme>), or if we can >>>> even use it given the ASF setup on GitHub. But I thought it would be worth >>>> mentioning nonetheless. >>>> >>>> On Sat, Jul 14, 2018 at 11:17 AM Holden Karau <hol...@pigscanfly.ca> >>>> wrote: >>>> >>>>> Hearing no objections (and in a shout out to @ Nicholas Chammas who >>>>> initially suggested mention-bot back in 2016) I've set up a copy of >>>>> mention >>>>> bot and run it against my own repo (looks like >>>>> https://github.com/holdenk/spark-testing-base/pull/253 ). >>>>> >>>>> If no one objects I’ll ask infra to turn this on for Spark on a trial >>>>> biases and we can revisit it based on how folks interact with it. >>>>> >>>>> On Wed, Jun 6, 2018 at 12:24 PM, Holden Karau <hol...@pigscanfly.ca> >>>>> wrote: >>>>> >>>>>> So there are a few bots along this line in OSS. If no one objects >>>>>> I’ll take a look and find one which matches our use case and try it out. >>>>>> >>>>>> On Wed, Jun 6, 2018 at 10:33 AM Sean Owen <sro...@gmail.com> wrote: >>>>>> >>>>>>> Certainly I will frequently dig through 'git blame' to figure out >>>>>>> who might be the right reviewer. Maybe that's automatable -- ping the >>>>>>> person who last touched the most lines touched by the PR? There might be >>>>>>> some false positives there. And I suppose the downside is being pinged >>>>>>> forever for some change that just isn't well considered or one of those >>>>>>> accidental 100K-line PRs. So maybe some way to decline or silence is >>>>>>> important, or maybe just ping once and leave it. Sure, a bot that just >>>>>>> adds >>>>>>> a "Would @foo like to review?" comment on Github? Sure seems worth >>>>>>> trying >>>>>>> if someone is willing to do the work to cook up the bot. >>>>>>> >>>>>>> On Wed, Jun 6, 2018 at 12:22 PM Holden Karau <hol...@pigscanfly.ca> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi friends, >>>>>>>> >>>>>>>> Was chatting with some folks at the summit and I was wondering how >>>>>>>> people would feel about adding a review bot to ping folks. We already >>>>>>>> have >>>>>>>> the review dashboard but I was thinking we could ping folks who were >>>>>>>> the >>>>>>>> original authors of the code being changed whom might not be in the >>>>>>>> habit >>>>>>>> of looking at the review dashboard. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> >>>>>>>> Holden :) >>>>>>>> -- >>>>>>>> Twitter: https://twitter.com/holdenkarau >>>>>>>> >>>>>>> -- >>>>>> Twitter: https://twitter.com/holdenkarau >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Twitter: https://twitter.com/holdenkarau >>>>> -- >>>>> Twitter: https://twitter.com/holdenkarau >>>>> >>>> -- >>> Twitter: https://twitter.com/holdenkarau >>> >>
