> On June 23, 2013, 3:39 p.m., Jarek Cecho wrote: > > Hi Masatake, > > I believe that depending on the PostgreSQL JDBC driver should be fine as > > long as the licensing is correct. I've took a look and the JDBC Driver is > > licensed using BSD license that is compatible with ASL and therefore I > > believe that depending on PostgreSQL JDBC driver should be fine. Please > > note that this is not the case for majority of other JDBC drivers for other > > vendors. > > > > I've just read the code (did not tried apply the patch nor run it) and it > > seems fine to me, so please do not hesitate and continue in the development > > process!
Hi Jarek, thanks for your comments. I got it. I am going to refine the code and add tests. - Masatake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12048/#review22304 ----------------------------------------------------------- On June 22, 2013, 4:28 p.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12048/ > ----------------------------------------------------------- > > (Updated June 22, 2013, 4:28 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Export with PostgreSQL Copy API can be realized in a straitforward way. > Attached file is not complete patch but sample implementation without tests > and consideration for corner cases. > Though this code resolves dependency for PostgreSQL JDBC by ivy, is it > acceptable for the project? > > > This addresses bug SQOOP-999. > https://issues.apache.org/jira/browse/SQOOP-999 > > > Diffs > ----- > > ivy.xml 750adfc > ivy/libraries.properties 430d554 > src/java/org/apache/sqoop/manager/PostgreSQLCopyManager.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportJob.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyMapper.java PRE-CREATION > > Diff: https://reviews.apache.org/r/12048/diff/ > > > Testing > ------- > > > Thanks, > > Masatake Iwasaki > >
