> On July 2, 2013, 7:50 p.m., Jarek Cecho wrote: > > src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportMapper.java, line 19 > > <https://reviews.apache.org/r/12048/diff/3/?file=314909#file314909line19> > > > > Nit: I'm slowly trying to clean up the giant package > > org.apache.sqoop.mapreduce. Would you mind putting this PostgreSQL specific > > implementation file into package org.apache.sqoop.mapreduce.postgresql? > > There are already packages for MySQL, Netezza or Microsoft SQL Server.
I'll move pg_bulkload related codes later in SQOOP-1118. - Masatake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12048/#review22678 ----------------------------------------------------------- On July 2, 2013, 9:28 p.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12048/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 9:28 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-999 > https://issues.apache.org/jira/browse/SQOOP-999 > > > Repository: sqoop-trunk > > > Description > ------- > > Export with PostgreSQL Copy API can be realized in a straitforward way. > Attached file is not complete patch but sample implementation without tests > and consideration for corner cases. > Though this code resolves dependency for PostgreSQL JDBC by ivy, is it > acceptable for the project? > > > Diffs > ----- > > ivy.xml 750adfc > ivy/libraries.properties 430d554 > src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java c085218 > src/java/org/apache/sqoop/mapreduce/postgresql/PostgreSQLCopyExportJob.java > PRE-CREATION > > src/java/org/apache/sqoop/mapreduce/postgresql/PostgreSQLCopyExportMapper.java > PRE-CREATION > src/test/com/cloudera/sqoop/manager/DirectPostgreSQLExportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/12048/diff/ > > > Testing > ------- > > > Thanks, > > Masatake Iwasaki > >
