----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12048/#review22570 -----------------------------------------------------------
Hi Masatake, thank you very much for all your effort! I do have couple of notes: src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportJob.java <https://reviews.apache.org/r/12048/#comment46290> The HCatalog integration is not supported right? src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyMapper.java <https://reviews.apache.org/r/12048/#comment46288> I would suggest to log the query for easier debugging. src/test/com/cloudera/sqoop/manager/DirectPostgreSQLExportManualTest.java <https://reviews.apache.org/r/12048/#comment46289> I would suggest to parametrise the build-in JDBC path similarly as is done in the PostgresqlTest class: https://github.com/apache/sqoop/blob/branch-1.4.0/src/test/com/cloudera/sqoop/manager/PostgresqlTest.java#L87 Jarcec - Jarek Cecho On June 24, 2013, 11:29 p.m., Masatake Iwasaki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12048/ > ----------------------------------------------------------- > > (Updated June 24, 2013, 11:29 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-999 > https://issues.apache.org/jira/browse/SQOOP-999 > > > Repository: sqoop-trunk > > > Description > ------- > > Export with PostgreSQL Copy API can be realized in a straitforward way. > Attached file is not complete patch but sample implementation without tests > and consideration for corner cases. > Though this code resolves dependency for PostgreSQL JDBC by ivy, is it > acceptable for the project? > > > Diffs > ----- > > ivy.xml 750adfc > ivy/libraries.properties 430d554 > src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java c085218 > src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyExportJob.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/PostgreSQLCopyMapper.java PRE-CREATION > src/test/com/cloudera/sqoop/manager/DirectPostgreSQLExportManualTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/12048/diff/ > > > Testing > ------- > > > Thanks, > > Masatake Iwasaki > >
