----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24507/#review50061 -----------------------------------------------------------
I didn't do a full review of the functionality, just a high level review. Two minor comments below. sqoop-patch-review.py <https://reviews.apache.org/r/24507/#comment87583> Once this is committed, you should add the config info to the "How to Contribute" wiki page. sqoop-patch-review.py <https://reviews.apache.org/r/24507/#comment87582> I think it should say Sqoop patch review tool? Also, usually a good thing to give an attribution to the original project/source code. - Hari Shreedharan On Aug. 8, 2014, 6:34 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24507/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 6:34 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1421 > https://issues.apache.org/jira/browse/SQOOP-1421 > > > Repository: sqoop-trunk > > > Description > ------- > > adding python script to make patch submission easier > > > Diffs > ----- > > sqoop-patch-review.py PRE-CREATION > > Diff: https://reviews.apache.org/r/24507/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
