----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24507/#review50084 -----------------------------------------------------------
Looks good except for a couple of suggestions: 1. There should be a way to see what will be posted to Review Board and Jira before actually doing it. A preview mode. 2. Configuration parameters as defaults for command line options seems good too. 3. Python logger might be better than just printing things to the command line (extensibility reasons). sqoop-patch-review.py <https://reviews.apache.org/r/24507/#comment87619> PATCH_SUBMISSION_HOME? Then default HOME if it doesn't exist? sqoop-patch-review.py <https://reviews.apache.org/r/24507/#comment87622> jira_config appears to be holding username and password only. Could it also hold "branch", "jira", "reviewboard", etc.? Essentially, it could act as a set of defaults for the options instead. sqoop-patch-review.py <https://reviews.apache.org/r/24507/#comment87618> or OptParse! sqoop-patch-review.py <https://reviews.apache.org/r/24507/#comment87623> Replace with python logger? - Abraham Elmahrek On Aug. 8, 2014, 6:51 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24507/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 6:51 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1421 > https://issues.apache.org/jira/browse/SQOOP-1421 > > > Repository: sqoop-trunk > > > Description > ------- > > adding python script to make patch submission easier > > > Diffs > ----- > > sqoop-patch-review.py PRE-CREATION > > Diff: https://reviews.apache.org/r/24507/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
