> On Aug. 8, 2014, 6:44 p.m., Hari Shreedharan wrote: > > sqoop-patch-review.py, line 35 > > <https://reviews.apache.org/r/24507/diff/2/?file=656611#file656611line35> > > > > I think it should say Sqoop patch review tool? > > > > Also, usually a good thing to give an attribution to the original > > project/source code. > > Gwen Shapira wrote: > Agree! > > Fixed the description to include attribution to Kafka tool. Let me know > if there's a more "official" place for this.
When I meant attribution, I meant as a comment in the code :-) - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24507/#review50061 ----------------------------------------------------------- On Aug. 8, 2014, 6:51 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24507/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 6:51 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1421 > https://issues.apache.org/jira/browse/SQOOP-1421 > > > Repository: sqoop-trunk > > > Description > ------- > > adding python script to make patch submission easier > > > Diffs > ----- > > sqoop-patch-review.py PRE-CREATION > > Diff: https://reviews.apache.org/r/24507/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
