----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/#review57867 -----------------------------------------------------------
Couple of last minute notes from my side as well :) core/pom.xml <https://reviews.apache.org/r/26678/#comment98744> Can we move the concrete implementation to it's own module? I would prefer not to introduce hadoop dependency on core. core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java <https://reviews.apache.org/r/26678/#comment98745> If the type is neither of "KERBEROS" nor "SIMPLE" can we try to use it as a classname and instantiate it? I would like to provide user ability to specify their own authentication class implementation if needed. This one can be probably done in follow up JIRA though :) core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationHandler.java <https://reviews.apache.org/r/26678/#comment98746> I would thrown an exception if the property AuthenticationConstants.AUTHENTICATION_KERBEROS_KEYTAB is not defined rather then trying some default location of the keytab - it majority of cases the default value won't be correct. core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationHandler.java <https://reviews.apache.org/r/26678/#comment98747> I would thrown an exception if the property AuthenticationConstants.AUTHENTICATION_KERBEROS_PRINCIPAL is not defined rather then trying some default value as in majority of cases the default value won't be correct. Jarcec - Jarek Cecho On Oct. 22, 2014, 7:44 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26678/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 7:44 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Kerberos support when starting service > > > Diffs > ----- > > core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandler.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationHandler.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationHandler.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > ac836c7cee010144696ab17645ccd008aed5762d > dist/src/main/server/conf/sqoop.properties > bb010166120321899425f84edb8e1ad6512626d2 > pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 > > Diff: https://reviews.apache.org/r/26678/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
