----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/#review57953 -----------------------------------------------------------
core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java <https://reviews.apache.org/r/26678/#comment98864> Remove `LOG.isTraceEnabled()`! core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java <https://reviews.apache.org/r/26678/#comment98863> Remove `LOG.isInfoEnabled()`! core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java <https://reviews.apache.org/r/26678/#comment98862> `LOG.trace()`? core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationHandler.java <https://reviews.apache.org/r/26678/#comment98861> To keep consistency, please remove the obivous comment from all LOG instances. And better run formatter once to keep code looks well. - Qian Xu On Oct. 22, 2014, 3:44 p.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26678/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 3:44 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Kerberos support when starting service > > > Diffs > ----- > > core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandler.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationHandler.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationHandler.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > ac836c7cee010144696ab17645ccd008aed5762d > dist/src/main/server/conf/sqoop.properties > bb010166120321899425f84edb8e1ad6512626d2 > pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 > > Diff: https://reviews.apache.org/r/26678/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
