> On Oct. 22, 2014, 7:19 p.m., Jarek Cecho wrote: > > core/pom.xml, lines 62-66 > > <https://reviews.apache.org/r/26678/diff/5/?file=728665#file728665line62> > > > > Can we move the concrete implementation to it's own module? I would > > prefer not to introduce hadoop dependency on core. > > richard zhou wrote: > Could the hadoop dependency be compile instead of provided? > I do not prefer to write a duplicate code to implement this, only because > to avoid adding hadoop dependency. > Could we use reflect (ClassUtils.loadClass)? > Or which component in sqoop could add hadoop dependency? excution? > submission? could we move KerberosAuthenticationHandler to this component or > create a security component to add haoop dependency? > > Veena Basavaraj wrote: > please no duplicate code. you will run out of sync sometime > > I like the idea of a security component and move thse things out of core > > Abraham Elmahrek wrote: > +1 on security component.
The way we designed Sqoop 2 is to push all Hadoop dependencies as far as possible, so that it's very easy to run Sqoop 2 without Hadoop. That is why execution engine sits in it's own separate module - in the core we have abstraction of execution engine that is implemented that separate module. I would like to see the same on the kerberos side, so that we have abstraction in the core, but the concrete implementation that brings huge amount of dependencies in separate module. This way the "core" module is very light in terms of dependencies and it's about the concrete components that brings all the dependencies and user can choose what dependencies they need based on what concrete components that wish to use. I would prefer not to break this one. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26678/#review57867 ----------------------------------------------------------- On Oct. 22, 2014, 7:44 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26678/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 7:44 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Kerberos support when starting service > > > Diffs > ----- > > core/pom.xml 2b6e436d637eb03493323e5b36e31e433c1f8bbb > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationConstants.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/authentication/AuthenticationError.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandler.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationHandlerFactory.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/AuthenticationManager.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/KerberosAuthenticationHandler.java > PRE-CREATION > > core/src/main/java/org/apache/sqoop/authentication/SimpleAuthenticationHandler.java > PRE-CREATION > core/src/main/java/org/apache/sqoop/core/SqoopServer.java > ac836c7cee010144696ab17645ccd008aed5762d > dist/src/main/server/conf/sqoop.properties > bb010166120321899425f84edb8e1ad6512626d2 > pom.xml f25a29f6db673e6080dcd5ccd51bab76ab38bff4 > > Diff: https://reviews.apache.org/r/26678/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
